Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cncf job migration test #444

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Cncf job migration test #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ capz/gmsa/configuration/configuration
capz/gmsa/configuration/gmsa-spec-writer-output.txt
helpers/hyper-v-mutating-webhook/bin/
capz/clusterctl
capz/tools
capz/tools
**/.vscode
7 changes: 6 additions & 1 deletion capz/run-capz-e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ main() {
export CI="${CI:-""}"

set_azure_envs

set_ci_version
IS_PRESUBMIT="$(capz::util::should_build_kubernetes)"
echo "IS_PRESUBMIT=$IS_PRESUBMIT"
Expand Down Expand Up @@ -378,10 +379,14 @@ run_e2e_test() {
fi

ADDITIONAL_E2E_ARGS=()
if [[ "$CI" == "true" ]]; then
if [[ "$CI" == "true" && -n "${DOCKER_CONFIG_FILE:-""}" ]]; then
# private image repository doesn't have a way to promote images: https://github.com/kubernetes/k8s.io/pull/1929
# So we are using a custom repository for the test "Container Runtime blackbox test when running a container with a new image should be able to pull from private registry with secret [NodeConformance]"
# Must also set label preset-windows-private-registry-cred: "true" on the job

# This will not work in community cluster as this secret is not present (hence we only do it if ENV is set)
# On the community cluster we will use credential providers to a private registry in azure see:
# https://github.com/kubernetes-sigs/windows-testing/issues/446
export KUBE_TEST_REPO_LIST="$SCRIPT_ROOT/../images/image-repo-list-private-registry"
ADDITIONAL_E2E_ARGS+=("--docker-config-file=${DOCKER_CONFIG_FILE}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be in the community sub, we will move this to a private registry in the private sub and use kubelet credential provider to access it. we need to wire this in to our templates but the credential binaries are already there kubernetes-sigs/cluster-api-provider-azure#4679 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#446

fi
Expand Down
Loading