Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullsync for vsphere CSI Driver #61

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

lipingxue
Copy link
Contributor

What this PR does / why we need it:
The goal for FullSync is to fetch data from CNS and comparing it with the local PV/PVC information in Kubernetes cluster to identify what volumes need to be created/updated/deleted in CNS. FullSync is designed to handle the case when Metadata Syncer cannot push down the data to vSphere as expected. Those cases includes, CNS goes down, csi driver goes down etc.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Integration, unit and e2e tests for FullSync will be added in the following PRs.

Release note:

FullSync for vSphere CSI Driver

@k8s-ci-robot
Copy link
Contributor

Welcome @lipingxue!

It looks like this is your first PR to kubernetes-sigs/vsphere-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/vsphere-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @lipingxue. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 6, 2019
@dvonthenen
Copy link
Contributor

@lipingxue looks like you need to sign the CLA
https://git.k8s.io/community/CLA.md#the-contributor-license-agreement

Copy link
Contributor

@codenrhoden codenrhoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small bit of feedback so far. Will ok-to-test once the CLA is in place.

pkg/syncer/metadatasyncer.go Outdated Show resolved Hide resolved
@lipingxue
Copy link
Contributor Author

@lipingxue looks like you need to sign the CLA
https://git.k8s.io/community/CLA.md#the-contributor-license-agreement

I just signed CLA.

@codenrhoden
Copy link
Contributor

we'll see if the CLA bot picks it up!

@codenrhoden
Copy link
Contributor

@lipingxue Your commit is under your personal address. We'll want it to be under your VMware address.

$ git show HEAD
commit dc400f1ade414ddb8c08db842d4f854d80423cd3 (HEAD, test/fullsync)
Author: Liping Xue <lipingxue@gmail.com>
Date:   Fri Sep 6 14:11:44 2019 -0700

Once you set your config correctly, you can change your single commit with:

git commit --amend --reset-author

@lipingxue
Copy link
Contributor Author

@codenrhoden It seems that CLA bot does not pick up my CLA. I signed the CLA using my personal email and the email account I used for my github account is my personal email. Does it matter?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 10, 2019
@lipingxue
Copy link
Contributor Author

@codenrhoden Ignore my previous update. cncf-cla is marded as "Yes" now.

@codenrhoden
Copy link
Contributor

@codenrhoden It seems that CLA bot does not pick up my CLA. I signed the CLA using my personal email and the email account I used for my github account is my personal email. Does it matter?

I know you said "ignore", but just for posterity -- yes it matters. The commits need to be with your VMware address for several reasons. I see that they are updated now, so thank you!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2019
@dvonthenen
Copy link
Contributor

Other than the comments @codenrhoden made, this seems pretty good to me! Awesome!

@codenrhoden
Copy link
Contributor

@lipingxue It looks like there are just a couple fixes to make re: goimports. The verify-fmt test failed because some of the imports not being listed alphabetically.

You can test this locally by running either make fmt or hack/check-format.sh.

pkg/syncer/types.go Outdated Show resolved Hide resolved
pkg/syncer/types.go Outdated Show resolved Hide resolved
@codenrhoden
Copy link
Contributor

This looks good to me! Please squash your commits and this is good to go.

Fullsync for vsphere CSI Driver

Address comments from Travis.

Address comments from Travis and Divyen.
Fix the fmt check.
@divyenpatel
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@codenrhoden
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, lipingxue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2c78e06 into kubernetes-sigs:master Sep 11, 2019
gnufied pushed a commit to gnufied/vsphere-csi-driver that referenced this pull request May 3, 2023
…ncy-openshift-4.14-vmware-vsphere-syncer

Updating vmware-vsphere-syncer images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants