Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s cluster distribution map to record EKS & AKS clusters #2880

Conversation

chethanv28
Copy link
Collaborator

@chethanv28 chethanv28 commented May 7, 2024

What this PR does / why we need it:
Update k8s cluster distribution map to record EKS & AKS

Example EKS server version:

Client Version: v1.24.0
Server Version: v1.24.0-eks-135321

Example AKS server version:

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.7"... }
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.7-aks" ... }

Special notes for your reviewer:

Release note:

Update k8s cluster distribution map to record EKS & AKS clusters

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2024
@k8s-ci-robot k8s-ci-robot requested review from adikul30 and xing-yang May 7, 2024 20:51
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 8, 2024
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit db59101 into kubernetes-sigs:master May 9, 2024
12 checks passed
chethanv28 added a commit to chethanv28/vsphere-csi-driver that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-3.3.0-candidate size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants