Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accessMode parameter in storageClassMap #476

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 1, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add accessMode parameter in storageClassMap

  • verified it works on local env
# k get pv local-pv-48445918 -o yaml
apiVersion: v1
kind: PersistentVolume
metadata:
  annotations:
    pv.kubernetes.io/provisioned-by: local-volume-provisioner-aks-azure-40425242-vmss000000-db96b70f-a23b-4920-86a4-b098adfc6b3c
  creationTimestamp: "2025-01-01T09:43:30Z"
  finalizers:
  - kubernetes.io/pv-protection
  name: local-pv-48445918
  resourceVersion: "100759036"
  uid: 8688b7b4-093c-4f1f-b23f-b553a93e9d18
spec:
  accessModes:
  - ReadWriteOncePod
  capacity:
    storage: 15Gi
  local:
    fsType: ext4
    path: /dev/disk/cloud/azure_resource-part1
  nodeAffinity:
    required:
      nodeSelectorTerms:
      - matchExpressions:
        - key: kubernetes.io/hostname
          operator: In
          values:
          - aks-azure-40425242-vmss000000
  persistentVolumeReclaimPolicy: Delete
  storageClassName: local-disk
  volumeMode: Filesystem
status:
  lastPhaseTransitionTime: "2025-01-01T09:43:30Z"
  phase: Available

Which issue(s) this PR fixes:

Fixes #467

Special notes for your reviewer:

Release note:

feat: add accessMode parameter in storageClassMap

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 1, 2025
@andyzhangx andyzhangx merged commit 695ff8a into kubernetes-sigs:master Jan 4, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【help】Automatically generated PV, how do I modify the access modes
2 participants