Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataSource label to pvcs created #128

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Add dataSource label to pvcs created #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,14 +1258,18 @@ func (ctrl *ProvisionController) checkFinalizer(volume *v1.PersistentVolume, fin

func (ctrl *ProvisionController) updateProvisionStats(claim *v1.PersistentVolumeClaim, err error, startTime time.Time) {
class := ""
source := ""
if claim.Spec.StorageClassName != nil {
class = *claim.Spec.StorageClassName
}
if claim.Spec.DataSource != nil {
source = claim.Spec.DataSource.Kind
}
if err != nil {
ctrl.metrics.PersistentVolumeClaimProvisionFailedTotal.WithLabelValues(class).Inc()
ctrl.metrics.PersistentVolumeClaimProvisionFailedTotal.WithLabelValues(class, source).Inc()
} else {
ctrl.metrics.PersistentVolumeClaimProvisionDurationSeconds.WithLabelValues(class).Observe(time.Since(startTime).Seconds())
ctrl.metrics.PersistentVolumeClaimProvisionTotal.WithLabelValues(class).Inc()
ctrl.metrics.PersistentVolumeClaimProvisionDurationSeconds.WithLabelValues(class, source).Observe(time.Since(startTime).Seconds())
ctrl.metrics.PersistentVolumeClaimProvisionTotal.WithLabelValues(class, source).Inc()
}
}

Expand Down
12 changes: 6 additions & 6 deletions controller/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,26 +67,26 @@ func New(subsystem string) Metrics {
prometheus.CounterOpts{
Subsystem: subsystem,
Name: "persistentvolumeclaim_provision_total",
Help: "Total number of persistent volumes provisioned succesfully. Broken down by storage class name.",
Help: "Total number of persistent volumes provisioned succesfully. Broken down by storage class name and source of the claim.",
},
[]string{"class"},
[]string{"class", "source"},
),
PersistentVolumeClaimProvisionFailedTotal: prometheus.NewCounterVec(
prometheus.CounterOpts{
Subsystem: subsystem,
Name: "persistentvolumeclaim_provision_failed_total",
Help: "Total number of persistent volume provision failed attempts. Broken down by storage class name.",
Help: "Total number of persistent volume provision failed attempts. Broken down by storage class name and source of the claim.",
},
[]string{"class"},
[]string{"class", "source"},
),
PersistentVolumeClaimProvisionDurationSeconds: prometheus.NewHistogramVec(
prometheus.HistogramOpts{
Subsystem: subsystem,
Name: "persistentvolumeclaim_provision_duration_seconds",
Help: "Latency in seconds to provision persistent volumes. Failed provisioning attempts are ignored. Broken down by storage class name.",
Help: "Latency in seconds to provision persistent volumes. Failed provisioning attempts are ignored. Broken down by storage class name and source of the claim.",
Buckets: prometheus.DefBuckets,
},
[]string{"class"},
[]string{"class", "source"},
),
PersistentVolumeDeleteTotal: prometheus.NewCounterVec(
prometheus.CounterOpts{
Expand Down