Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le #2589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pranitaT
Copy link

@pranitaT pranitaT commented Dec 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables the Security Profiles Operator for the ppc64le architecture, providing support for managing seccomp and SELinux profiles. The changes have been tested and verified using logenricher to ensure functionality and compliance.

Which issue(s) this PR fixes: https://issues.redhat.com/browse/MULTIARCH-4654

Does this PR have test?

N/A

Special notes for your reviewer:

  • Tested for compatibility with seccomp and SELinux profiles on the ppc64le architecture.
  • Verified functionality using logenricher.

Does this PR introduce a user-facing change?

Enabled the Security Profiles Operator for `ppc64le` architecture with support for seccomp and SELinux profile management.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 2, 2024
Copy link

linux-foundation-easycla bot commented Dec 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pranitaT / name: Pranita Turrey (18f0e45)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @pranitaT!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @pranitaT. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 2, 2024
@saschagrunert
Copy link
Member

Thank you for the PR @pranitaT, do you mind signing the CLA?

@prb112
Copy link

prb112 commented Dec 2, 2024

Hey @saschagrunert I shared with Pranita how our team signs the CLA. We'll get this done a.s.a.p. Thank you for the time, Paul

@saschagrunert
Copy link
Member

Please rebase to fix the CI

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 4, 2024
@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch 3 times, most recently from 57bc010 to afbcb5b Compare December 4, 2024 06:40
@saschagrunert
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2024
@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch 5 times, most recently from f889b64 to 98c7a11 Compare December 5, 2024 12:13
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 20, 2025
@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch from cbc613e to b83ca02 Compare January 21, 2025 06:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.26%. Comparing base (11d77f4) to head (18f0e45).
Report is 710 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
- Coverage   45.50%   41.26%   -4.24%     
==========================================
  Files          79      117      +38     
  Lines        7782    19725   +11943     
==========================================
+ Hits         3541     8140    +4599     
- Misses       4099    11048    +6949     
- Partials      142      537     +395     

@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch 2 times, most recently from feafbbd to efec1f0 Compare January 24, 2025 11:14
@@ -23,15 +23,17 @@ USER root
WORKDIR /work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build seems to fail:

69.70 internal/pkg/daemon/bpfrecorder/bpfrecorder_linux_amd64.go:26:9: undefined: toStringInt8
69.70 internal/pkg/daemon/bpfrecorder/bpfrecorder_linux_amd64.go:31:9: undefined: toStringInt8

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow-up with Pranita, thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a PR for Pranita to use as a basis of the fix pranitaT#3

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
@saschagrunert
Copy link
Member

Unfortunately, this one needs a rebase now.

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 30, 2025
@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch from ed1dd7e to a642aab Compare January 30, 2025 14:36
@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch 4 times, most recently from 19bc583 to 6a5af67 Compare February 6, 2025 06:50
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pranitaT, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@prb112
Copy link

prb112 commented Feb 6, 2025

/retest

@pranitaT
Copy link
Author

Hi @saschagrunert,
Could you please initiate a retest for this PR?
Thank you!

@Vincent056
Copy link
Contributor

/retest

@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch from 6a5af67 to 03c6467 Compare February 12, 2025 07:08
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
…dded fixes for seccomp and SELinux profiles, and verified functionality with logenricher.

Signed-off-by: Pranita Turrey <pranita.turrey@ibm.com>
@pranitaT pranitaT force-pushed the nov24-ppc64le-support branch from 03c6467 to 18f0e45 Compare February 12, 2025 07:10
@prb112
Copy link

prb112 commented Feb 12, 2025

Thanks @pranita

Creating the dummy commit and removing it did wonders.

I looked at the run and most of the action/workflows are passing.
The one failure is e2e-apparmor-profile lint to workflow run

2025-02-12T07:44:43.7769765Z [pod/security-profiles-operator-7986b75f5b-zc6fm/security-profiles-operator] E0212 07:44:34.153933       1 reflector.go:166] "Unhandled Error" err="k8s.io/client-go@v0.32.1/tools/cache/reflector.go:251: Failed to watch *v1alpha1.AppArmorProfile: failed to list *v1alpha1.AppArmorProfile: apparmorprofiles.security-profiles-operator.x-k8s.io is forbidden: User \"system:serviceaccount:security-profiles-operator:security-profiles-operator\" cannot list resource \"apparmorprofiles\" in API group \"security-profiles-operator.x-k8s.io\" at the cluster scope" logger="UnhandledError"

We should look at it locally and see if we replicate; unless @saschagrunert or @Vincent056 says otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants