-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTIARCH-4654: Enabled the Security Profiles Operator for ppc64le #2589
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @pranitaT! |
Hi @pranitaT. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thank you for the PR @pranitaT, do you mind signing the CLA? |
Hey @saschagrunert I shared with Pranita how our team signs the CLA. We'll get this done a.s.a.p. Thank you for the time, Paul |
Please rebase to fix the CI |
57bc010
to
afbcb5b
Compare
/ok-to-test |
f889b64
to
98c7a11
Compare
cbc613e
to
b83ca02
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
==========================================
- Coverage 45.50% 41.26% -4.24%
==========================================
Files 79 117 +38
Lines 7782 19725 +11943
==========================================
+ Hits 3541 8140 +4599
- Misses 4099 11048 +6949
- Partials 142 537 +395 |
feafbbd
to
efec1f0
Compare
@@ -23,15 +23,17 @@ USER root | |||
WORKDIR /work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build seems to fail:
69.70 internal/pkg/daemon/bpfrecorder/bpfrecorder_linux_amd64.go:26:9: undefined: toStringInt8
69.70 internal/pkg/daemon/bpfrecorder/bpfrecorder_linux_amd64.go:31:9: undefined: toStringInt8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow-up with Pranita, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a PR for Pranita to use as a basis of the fix pranitaT#3
Unfortunately, this one needs a rebase now. |
ed1dd7e
to
a642aab
Compare
19bc583
to
6a5af67
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pranitaT, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Hi @saschagrunert, |
/retest |
6a5af67
to
03c6467
Compare
New changes are detected. LGTM label has been removed. |
…dded fixes for seccomp and SELinux profiles, and verified functionality with logenricher. Signed-off-by: Pranita Turrey <pranita.turrey@ibm.com>
03c6467
to
18f0e45
Compare
Thanks @pranita Creating the dummy commit and removing it did wonders. I looked at the run and most of the action/workflows are passing.
We should look at it locally and see if we replicate; unless @saschagrunert or @Vincent056 says otherwise. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables the Security Profiles Operator for the ppc64le architecture, providing support for managing seccomp and SELinux profiles. The changes have been tested and verified using logenricher to ensure functionality and compliance.
Which issue(s) this PR fixes: https://issues.redhat.com/browse/MULTIARCH-4654
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?