Reduce complexity

kubernetes-sigs · Jan 23, 2024 · 58cc418 · 58cc418
1 parent 21f80fd
commit 58cc418
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/internal/pkg/webhooks/binding/binding.go b/internal/pkg/webhooks/binding/binding.go
@@ -205,16 +205,14 @@ func (p *podBinder) updatePod(ctx context.Context, profilebindings []profilebind
 		}
 	}
 
-	if !podChanged {
-		if podBindProfile == nil || podProfileBinding == nil {
-			return pod, admission.Allowed("pod unchanged")
-		}
-		podChanged = p.addPodSecurityContext(pod, *podBindProfile)
-		if podChanged {
-			if err := p.addPodToBinding(ctx, podID, podProfileBinding); err != nil {
-				return pod, admission.Errored(http.StatusInternalServerError, err)
-			}
-		}
+	if !podChanged && (podBindProfile == nil || podProfileBinding == nil) {
+		return pod, admission.Allowed("pod unchanged")
+	}
+	if !p.addPodSecurityContext(pod, *podBindProfile) {
+		return pod, admission.Allowed("pod unchanged")
+	}
+	if err := p.addPodToBinding(ctx, podID, podProfileBinding); err != nil {
+		return pod, admission.Errored(http.StatusInternalServerError, err)
 	}
 	return pod, admission.Response{}
 }