Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump trivy to v0.57.1 and use golang:1.22 in dockerfile #1693

Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 19, 2024

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ritazh and tam7t November 19, 2024 15:50
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2024
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/c/fix_trivy_rate_limit branch from 22bd6b7 to c5d2bd3 Compare November 19, 2024 15:50
@aramase aramase changed the title Aramase/c/fix trivy rate limit chore: bump trivy to v0.57.1 to mitigate rate limit issues Nov 19, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.54%. Comparing base (87f51ec) to head (041d142).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
+ Coverage   35.83%   36.54%   +0.71%     
==========================================
  Files          63       63              
  Lines        3759     4526     +767     
==========================================
+ Hits         1347     1654     +307     
- Misses       2268     2729     +461     
+ Partials      144      143       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozercan
Copy link
Contributor

@aramase you might need to add mirrors to address this, see: https://github.com/open-policy-agent/gatekeeper/pull/3696/files

@aramase
Copy link
Member Author

aramase commented Dec 4, 2024

@aramase you might need to add mirrors to address this, see: https://github.com/open-policy-agent/gatekeeper/pull/3696/files

@sozercan I bumped it to v0.57.1 that has mirror.gcr.io (xref: aquasecurity/trivy#7668 (comment)).

@aramase aramase changed the title chore: bump trivy to v0.57.1 to mitigate rate limit issues chore: bump trivy to v0.57.1 and use latest golang image in dockerfile Dec 4, 2024
@aramase aramase force-pushed the aramase/c/fix_trivy_rate_limit branch from dd0c32e to 80c395c Compare December 4, 2024 21:11
@aramase aramase changed the title chore: bump trivy to v0.57.1 and use latest golang image in dockerfile chore: bump trivy to v0.57.1 and use golang:1.22 in dockerfile Dec 4, 2024
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/c/fix_trivy_rate_limit branch from 80c395c to 041d142 Compare December 4, 2024 21:17
@aramase
Copy link
Member Author

aramase commented Dec 4, 2024

/assign @enj

@aramase
Copy link
Member Author

aramase commented Dec 4, 2024

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@aramase: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@enj
Copy link
Contributor

enj commented Dec 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 714e758 into kubernetes-sigs:main Dec 5, 2024
24 checks passed
@aramase aramase deleted the aramase/c/fix_trivy_rate_limit branch December 5, 2024 19:32
@k8s-infra-cherrypick-robot

@aramase: new pull request created: #1702

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants