Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing aggregation ClusterRoles for SecretProviderClasses #835

Closed
anapsix opened this issue Jan 11, 2022 · 0 comments · Fixed by #836
Closed

missing aggregation ClusterRoles for SecretProviderClasses #835

anapsix opened this issue Jan 11, 2022 · 0 comments · Fixed by #836
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@anapsix
Copy link
Contributor

anapsix commented Jan 11, 2022

Describe the solution you'd like
At the moment, there are no ClusterRoles created for SecretProviderClasses resources with aggregation to view and admin default roles. This prevents ClusterRole/admin and ClusterRole/view from accessing SecretProviderClasses resources.

It would be helpful to create a default roles with admin and view permissions, taking advantage of aggregation functionality to update default RBAC roles.
@anapsix anapsix added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 11, 2022
anapsix added a commit to anapsix/secrets-store-csi-driver that referenced this issue Jan 11, 2022
@anapsix
additional cluster roles for secretproviderclasses
ab2170c 
Adding Admin and Viewer cluster roles, aggregaring to default "admin"
and "view" ClusterRoles.
Closes kubernetes-sigs#835.
anapsix added a commit to anapsix/secrets-store-csi-driver that referenced this issue Jan 11, 2022
@anapsix
additional cluster roles for secretproviderclasses
fb30fa3 
Adding Admin and Viewer cluster roles, aggregaring to default "admin"
and "view" ClusterRoles.
Fixes kubernetes-sigs#835
@anapsix anapsix mentioned this issue Jan 11, 2022
Merged
anapsix added a commit to anapsix/secrets-store-csi-driver that referenced this issue Jan 11, 2022
@anapsix
feature: additional cluster roles for secretproviderclasses
98bf1f1 
Adding Admin and Viewer cluster roles, aggregaring to default "admin"
and "view" ClusterRoles.
Fixes kubernetes-sigs#835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

helm: additional cluster roles for secretproviderclasses anapsix/secrets-store-csi-driver
1 participant
@anapsix