-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass existing context without using TODO() #728
Conversation
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @googs1025 . Could you also fix context.Background()
in non-test code? (we can fix tests later)
pkg/capacityscheduling/capacity_scheduling.go
140: elasticQuotaInformer, err := dynamicCache.GetInformer(context.Background(), &v1alpha1.ElasticQuota{})
705: if err := c.client.List(context.Background(), &eqList, client.InNamespace(pod.Namespace)); err != nil {
pkg/noderesourcetopology/cache/overreserve.go
67: if err := client.List(context.Background(), nrtObjs); err != nil {
229: if err := ov.client.Get(context.Background(), types.NamespacedName{Name: nodeName}, nrtCandidate); err != nil {
pkg/noderesourcetopology/podprovider/podprovider.go
47: ctx := context.Background()
done. I have also made changes to some related test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?