Skip to content

Commit

Permalink
Merge pull request #764 from googs1025/fix_comment
Browse files Browse the repository at this point in the history
chore: fix EventsToRegister method comment
  • Loading branch information
k8s-ci-robot authored Jul 25, 2024
2 parents 0759578 + 2d9af55 commit 228fb87
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion pkg/capacityscheduling/capacity_scheduling.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ func New(ctx context.Context, obj runtime.Object, handle framework.Handle) (fram

func (c *CapacityScheduling) EventsToRegister() []framework.ClusterEventWithHint {
// To register a custom event, follow the naming convention at:
// https://git.k8s.io/kubernetes/pkg/scheduler/eventhandlers.go#L403-L410
// https://github.com/kubernetes/kubernetes/pull/101394
// Please follow: eventhandlers.go#L403-L410
eqGVK := fmt.Sprintf("elasticquotas.v1alpha1.%v", scheduling.GroupName)
return []framework.ClusterEventWithHint{
{Event: framework.ClusterEvent{Resource: framework.Pod, ActionType: framework.Delete}},
Expand Down
3 changes: 2 additions & 1 deletion pkg/coscheduling/coscheduling.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ func New(_ context.Context, obj runtime.Object, handle framework.Handle) (framew

func (cs *Coscheduling) EventsToRegister() []framework.ClusterEventWithHint {
// To register a custom event, follow the naming convention at:
// https://git.k8s.io/kubernetes/pkg/scheduler/eventhandlers.go#L403-L410
// https://github.com/kubernetes/kubernetes/pull/101394
// Please follow: eventhandlers.go#L403-L410
pgGVK := fmt.Sprintf("podgroups.v1alpha1.%v", scheduling.GroupName)
return []framework.ClusterEventWithHint{
{Event: framework.ClusterEvent{Resource: framework.Pod, ActionType: framework.Add}},
Expand Down
3 changes: 2 additions & 1 deletion pkg/noderesourcetopology/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ func New(ctx context.Context, args runtime.Object, handle framework.Handle) (fra
// that make other Pods schedulable.
func (tm *TopologyMatch) EventsToRegister() []framework.ClusterEventWithHint {
// To register a custom event, follow the naming convention at:
// https://git.k8s.io/kubernetes/pkg/scheduler/eventhandlers.go#L403-L410
// https://github.com/kubernetes/kubernetes/pull/101394
// Please follow: eventhandlers.go#L403-L410
nrtGVK := fmt.Sprintf("noderesourcetopologies.v1alpha2.%v", topologyapi.GroupName)
return []framework.ClusterEventWithHint{
{Event: framework.ClusterEvent{Resource: framework.Pod, ActionType: framework.Delete}},
Expand Down

0 comments on commit 228fb87

Please sign in to comment.