sign: IsImageSigned() #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a function to check if an image reference is signed. As some of the image verification methods are still hidden behind the cosign API, we need to check for image signatures to decide if verification is needed or not. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Add iunit test for IsImageSigned() method, checks to ensure if image is signed, not signed and error. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
requested review from
cpanato,
palnabarun,
PushkarJ,
saschagrunert and
xmudrii
k8s-ci-robot
added
cncf-cla: yes
This was referenced Feb 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thit PR introduces a new method to the signer object
IsImageSigned()which returns a bool indicating if an image reference has signatures attached to it.This is needed because we need to know if images are signed before triggering image verification on a reference.
Needed for verifying images in the container image promoter: kubernetes-sigs/promo-tools#498
Related to
kubernetes/release#2383
kubernetes/release#2227
/cc @saschagrunert @cpanato @xmudrii @PushkarJ @palnabarun