Tide blocks PRs which have checks with "skipped" status

[sbueringer]

Since a few days (I think since the weekend) tide is not merging PRs with skipped actions anymore.

It reports: Pending — Not mergeable. Job Approve ok-to-test has not succeeded.

For full context, see: https://kubernetes.slack.com/archives/C09QZ4DQB/p1713803378307299

It looks like GitHub changed the "check-runs" API to additionally return a "skipped" status which is not handled in

prow/pkg/tide/tide.go

Lines 2133 to 2139 in a25fe4d

	if checkRun.Conclusion == checkRunConclusionNeutral || checkRun.Conclusion == githubql.String(githubql.StatusStateSuccess) {
	context.State = githubql.StatusStateSuccess
	return context
	}
	context.State = githubql.StatusStateFailure
	return context

Some referenced:

• Our action: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml
• Some blocked PRs:
  • 🌱 Store nightly manifests in k8s-staging-capi-vsphere cluster-api-provider-vsphere#2930
  • 🌱 Bump envtest to v1.30.0 cluster-api#10477

This will affect a few more repositories as just this action alone was copy&pasted across a few repos: ~ https://cs.k8s.io/?q=%27ok-to-test%27&i=nope&files=&excludeFiles=&repos=

[tuminoid]

+1. We also hit same in Metal3 today. Skipped optional action was blocking tide from merging. Worked around it by editing PR title which causes actions to run again, and then tide agreed to merge.

[cardil]

+1. This affects a lot of Knative repos. For example: knative/serving#15147

[dprotaso]

Oddly the Check run API isn't returning skipped jobs ATM

gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/knative/serving/commits/acdcf4fd9bad1fce9f17a29f3638ede1833cf8c9/check-runs | jq '.check_runs | .[] | .name'

[dprotaso]

I think I'm hitting the wrong endpoint cause when I create new PRs the tide is still blocking it on skipped checks

[JohnNiang]

I faced the same problem yesterday.

{
      "id": 24134812784,
      "name": "github-release",
      "node_id": "CR_kwDOB4VVe88AAAAFnowEcA",
      "head_sha": "ff334baa39e8d8ff74886c5d9b6de342f1f6ae5b",
      "external_id": "4ff2e047-c2ab-5477-8844-6e71b9d83ccc",
      "url": "https://api.github.com/repos/halo-dev/halo/check-runs/24134812784",
      "html_url": "https://github.com/halo-dev/halo/actions/runs/8751217578/job/24134812784",
      "details_url": "https://github.com/halo-dev/halo/actions/runs/8751217578/job/24134812784",
      "status": "completed",
      "conclusion": "skipped",
      "started_at": "2024-04-23T04:23:25Z",
      "completed_at": "2024-04-23T04:23:25Z",
      "output": {
        "title": null,
        "summary": null,
        "text": null,
        "annotations_count": 0,
        "annotations_url": "https://api.github.com/repos/halo-dev/halo/check-runs/24134812784/annotations"
       }
}

I'm using version v20231103-74dcf8db5c.

[saschagrunert]

@sbueringer are you already working on a fix for this?

[sbueringer]

@saschagrunert No, mostly because I'm not familiar with the code base and I don't know if it is more than just adjusting that one single if

[saschagrunert]

Working towards a fix in #131

[saschagrunert]

It works, PR's like kubernetes-sigs/security-profiles-operator#2225 merge again. :)

[sbueringer]

Thank you very much!