Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change apiregistration.k8s.io to v1 #494

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Change apiregistration.k8s.io to v1 #494

merged 1 commit into from
Jul 7, 2022

Conversation

grzesuav
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @grzesuav. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2022
@grzesuav grzesuav mentioned this pull request Mar 23, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2022
@grzesuav
Copy link
Contributor Author

grzesuav commented Jul 1, 2022

hi @dgrisonnet , any chance taking a look on this PR ?

@dgrisonnet
Copy link
Member

Thank you for updating this @grzesuav :)

/remove-lifecycle stale
/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, grzesuav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 508b82b into kubernetes-sigs:master Jul 7, 2022
monitoring-commit-bot bot pushed a commit to rhobs/k8s-prometheus-adapter that referenced this pull request Aug 13, 2022
@github-actions
Merge tag 'refs/tags/v0.10.0'
af53231 
Changes since v0.9.1

Deprecation:
* Logging flags that are klog specific (--log-dir, --log-file, --logtostderr, --alsologtostderr, --one-output, --stderrthreshold, --log-file-max-size, --skip-log-headers, --add-dir-header, --skip-headers, --log-backtrace-at) are deprecated and will be removed following Kubernetes v1.25 release. More details are available in [KEP-2845](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components).

Improvements:
* Add new `--prometheus-verb` CLI flag to configure the HTTP verb used by prometheus-adapter when querying Prometheus. kubernetes-sigs#509 (@ksauzz)
* Update Kubernetes dependencies to v1.24 and golang version to v1.18.5. kubernetes-sigs#521 (@dgrisonnet)

Bug fixes:
* Fix a bug where the config file wasn't closed in some scenarios. kubernetes-sigs#498 (@lokichoggio)

Documentation:
* Add documentation about Helm3 installation. kubernetes-sigs#491 (@Ruwan-Ranganath)
* Update apiregistration.k8s.io to v1 in the manifests. kubernetes-sigs#494 (@grzesuav)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grzesuav @k8s-ci-robot @k8s-triage-robot @dgrisonnet