Populate metric selector for custom metrics #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying custom-metrics, the metric label selectors weren't populated in the resulting values. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
dgrisonnet
commented
Dec 10, 2020
| } | ||
|
|
||
| func (p *prometheusProvider) metricsFor(valueSet pmodel.Vector, info provider.CustomMetricInfo, namespace string, names []string) (*custom_metrics.MetricValueList, error) { | ||
| func (p *prometheusProvider) metricsFor(valueSet pmodel.Vector, namespace string, names []string, info provider.CustomMetricInfo, metricSelector labels.Selector) (*custom_metrics.MetricValueList, error) { |
There was a problem hiding this comment.
note: I changed the order of the parameters here to match the metricFor function
|
lgtm, thank you! |
|
@dgrisonnet just because i simply forgot: as a follow-up we could potentially add some tests, wdyt? |
|
yes, that would definitely be a great addition. However, since I am not too familiar with prometheus-adapter test framework, it might take me some times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying custom-metrics, the metric label selectors weren't populated in the resulting values.
A query with a metricLabelSelector query parameter set to
endpoint=httpswas resulting in the following MetricValueList:With this change, it now appears as:
/cc @s-urbaniak