-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Update sig storage lib external provisioner to v9.0.3 #358
[WIP]Update sig storage lib external provisioner to v9.0.3 #358
Conversation
@mengjiao-liu: GitHub didn't allow me to request PR reviews from the following users: cornfeedhobo. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mengjiao-liu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for taking this on! Is there any plan to update the helm chart version after this too? It seems to be stuck in time, even though the controller has been bumped up many times since the last helm release. |
IIUC, the helm chart version has been updated from |
I have tested on the K8s cluster (v1.19+) and everything ran successfully, but the e2e tests for this repository have not yet run successfully. There is not enough time to test e2e. /close |
@mengjiao-liu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
The previous PR #258 has not been updated for more than a year and has been closed.
#258 (comment)
The k/k test code requires nfs-subdir-external-provisioner to be updated to v8.0.0 +
kubernetes/kubernetes#114804 (comment)
Special notes for your reviewer:
The reason for not upgrading to the latest version v10.0.1 of sig-storage-lib-external-provisioner:
Because starting from v10.0.0, sig-storage-lib-external-provisioner added contextual logging. If we want to update to the latest version, all glog codes in this repository need to be updated to klog codes. I am not sure whether it is necessary to update, After all, it involves a lot of log content updates, which need to be discussed by the reviewer of nfs-subdir-external-provisioner.
Another way is to update it in a later PR.
/cc @yonatankahana @cornfeedhobo
I still need to test it on the cluster to make sure it works correctly, and when the test is complete, I will remove the WIP keyword.