Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nfs-subdir-external-provisioner] No restrictions on PVC #51

Closed
m4r1k opened this issue Feb 11, 2021 · 9 comments
Closed

[nfs-subdir-external-provisioner] No restrictions on PVC #51

m4r1k opened this issue Feb 11, 2021 · 9 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@m4r1k
Copy link

m4r1k commented Feb 11, 2021

Hey there,

I'm merely linking the former nfs-client-provisioner issue about the quota here.
kubernetes-retired/external-storage#1301

Would be really handy having this included as well

@yonatankahana
Copy link
Contributor

i believe it will be possible using the quota.go that @wongma7 wrote.
@wongma7 - do you have any idea if this is gonna work?

@wongma7
Copy link
Contributor

wongma7 commented Feb 16, 2021

quota.go is very limited, it relies on the volume backing the NFS store to be XFS and the provisioner has to be privileged. Even then it might not work, depending on container runtime and such.

I think a more generic quota/restriction mechanism is not feasible since NFS doesn't support it. : /

To enforce per-PVC quota, the server would have to poll disk usage and then somehow block writes after quota exceeded...

To enforce per-server/provisioner quota, the server would have to poll disk usage and then reject PVCs once quota is exceeded.

@yonatankahana
Copy link
Contributor

yonatankahana commented Feb 21, 2021

PVC sizes are requests but not necessarily limitations. the matching PV should be at least the size of the PVC and it is not guaranteed that this size is really available nor enforced - by design.
in dynamic provisioning it is possible to allocate/control the size of the created volume, but NFS exports are not volumes but directories and sounds like there is no good way to set quota on those directories (at least not a standard way, i don't even like the xfs way since it is privileged).
it makes me think that although it is technically possible, the provisioner should not be responsible for that.

@wongma7 wdyt?

@ShamoX
Copy link

ShamoX commented Apr 6, 2021

Hello,

Isn't this: https://serverfault.com/a/100628 could be a solution ? When provisioning a volume, you create a dedicated directory anyway. Then you just ensure the mount of a file with the right size.

I do agree that the PVC sizes are requests and not limits, but, since you can't limit others, you can't either guarantee the size requested...
Using mounted files on the NFS volume could allow all the functionalities (resizing is possible - even to a smaller size, when data on the volume allows it).

@toms-place
Copy link

Did someone try to use XFS on the NFS Server for quotas already?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 9, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants