Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flag to produce individual yaml files #929

Closed
wants to merge 2 commits into from
Closed

Added flag to produce individual yaml files #929

wants to merge 2 commits into from

Conversation

tarmazakov
Copy link

Resolve #897

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tarmazakov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liujingfang1

If they are not already assigned, you can assign the PR to them by writing /assign @liujingfang1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 28, 2019
@monopole monopole mentioned this pull request Mar 28, 2019
Closed
@monopole
Copy link
Contributor

Thanks for this! We cannot take it as is, as there are some problems here, but more importantly the actual problem statement isn't clear over in #897. I've asked for clarification.

@monopole
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2019
monopole
monopole reviewed Mar 28, 2019
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments in #897

@monopole
Copy link
Contributor

monopole commented Apr 8, 2019

Closing till we get clarification on how this could work in #897. Thanks!

@monopole monopole closed this Apr 8, 2019
@zeeZ zeeZ mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole monopole left review comments

@droot droot Awaiting requested review from droot

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarmazakov @k8s-ci-robot @monopole