Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Kueue features overview page #3879

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Dec 18, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

To refresh the "features overview" section after a couple of new features recently added (0.9 and 0.10).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I have not included yet:

  • HierarchicalCohorts - they are Alpha and I couldn't find a good docs link cc @gabesaba
  • LocalQueue defaulting - IIUC the section focuses on people who don't use Kueue yet, to attract them, but this feature is more relevant to already users of Kueue - it rather fixes the problem with complex setup, rather than gives a new "capability" - but I'm open to discussion and including it cc @yaroslava-serdiuk

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 3a047ca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6763c0752be9ea0008f4ed6e

@mimowo
Copy link
Contributor Author

mimowo commented Dec 18, 2024

@mimowo
Copy link
Contributor Author

mimowo commented Dec 18, 2024

/hold
to avoid premature merging, I would like to hear multiple lgtm first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@yaroslava-serdiuk
Copy link
Contributor

LocalQueue defaulting - IIUC the section focuses on people who don't use Kueue yet

Not really. The original issue that feature solves comes from users that familiar with Kueue: #2936

@mimowo
Copy link
Contributor Author

mimowo commented Dec 18, 2024

Not really. The original issue that feature solves comes from users that familiar with Kueue: #2936

Yes, the LocalQueue defaulting is mostly relevant to folks who are already onboarded to Kueue, while the audience for the "feature overview" section is mostly new potential users.

@yaroslava-serdiuk
Copy link
Contributor

Yes, the LocalQueue defaulting is mostly relevant to folks who are already onboarded to Kueue, while the audience for the "feature overview" section is mostly new potential users.

Oh, I see, sorry I misunderstand you.
Anyway I think it would be nice to link all features that Kueue supports.

@mimowo
Copy link
Contributor Author

mimowo commented Dec 18, 2024

Anyway I think it would be nice to link all features that Kueue supports.

Right, let me try to accommodate that: 78169c0, wdyt?

@yaroslava-serdiuk
Copy link
Contributor

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 18283a981fd9ff5f5f7fdfa90505ab10a82a348b

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@mimowo mimowo force-pushed the refresh-feature-overview branch from 5d93805 to db2d640 Compare December 18, 2024 18:20
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.
basically, lgtm

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e343dc72476a8c9d00c4aa5c0a7179ee4860017

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mwielgus, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mimowo
Copy link
Contributor Author

mimowo commented Dec 19, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Dec 19, 2024

/cherry-pick website

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you.

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit b5e745a into kubernetes-sigs:main Dec 19, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Dec 19, 2024
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #3888

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants