-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh Kueue features overview page #3879
Refresh Kueue features overview page #3879
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/hold |
Not really. The original issue that feature solves comes from users that familiar with Kueue: #2936 |
Yes, the LocalQueue defaulting is mostly relevant to folks who are already onboarded to Kueue, while the audience for the "feature overview" section is mostly new potential users. |
Oh, I see, sorry I misunderstand you. |
Right, let me try to accommodate that: 78169c0, wdyt? |
/lgtm |
LGTM label has been added. Git tree hash: 18283a981fd9ff5f5f7fdfa90505ab10a82a348b
|
5d93805
to
db2d640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit.
basically, lgtm
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
LGTM label has been added. Git tree hash: 3e343dc72476a8c9d00c4aa5c0a7179ee4860017
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, mwielgus, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/cherry-pick website |
@mimowo: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mimowo: new pull request created: #3888 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
To refresh the "features overview" section after a couple of new features recently added (0.9 and 0.10).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I have not included yet:
Does this PR introduce a user-facing change?