-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy. #3747
Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy. #3747
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
4ee53ba
to
3b36878
Compare
…8s.io/kubebuilder/kube-rbac-proxy.
3b36878
to
39effc1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 2876ae3bab2507e879f8a386c6333e6212487e66
|
I think that this is fine for now but in that doc they say this is risky..
|
Yeah, this is a quick fix as the 0.10 is approaching. We will update the solution when details of using controller-runtime as replacement are figured out. |
Let me cherry-pick this solution to make sure all release branches are aligned |
/cherry-pick release-0.8 |
@mimowo: new pull request created: #3749 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mimowo: #3747 failed to apply on top of branch "release-0.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy.
For more details: kubernetes-sigs/kubebuilder#3907
Which issue(s) this PR fixes:
Part of #3737
Special notes for your reviewer:
Does this PR introduce a user-facing change?