Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy. #3747

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy.

For more details: kubernetes-sigs/kubebuilder#3907

Which issue(s) this PR fixes:

Part of #3737

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2024
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 39effc1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6751dea6afd46f00086f52e2

@mbobrovskyi mbobrovskyi force-pushed the cleanup/use-the-mirror-image-kube-rbac-proxy branch from 4ee53ba to 3b36878 Compare December 5, 2024 17:09
…8s.io/kubebuilder/kube-rbac-proxy.
@mbobrovskyi mbobrovskyi force-pushed the cleanup/use-the-mirror-image-kube-rbac-proxy branch from 3b36878 to 39effc1 Compare December 5, 2024 17:11
@mimowo
Copy link
Contributor

mimowo commented Dec 5, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2876ae3bab2507e879f8a386c6333e6212487e66

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 93d563a into kubernetes-sigs:main Dec 5, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Dec 5, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/use-the-mirror-image-kube-rbac-proxy branch December 5, 2024 17:48
@kannon92
Copy link
Contributor

kannon92 commented Dec 5, 2024

I think that this is fine for now but in that doc they say this is risky..

To mitigate risks, we manually mirror the images to registry.k8s.io/kubebuilder/kube-rbac-proxy. This registry is managed by the #sig-k8s-infra. However, we cannot promote the kube-rbac-proxy images on this registry or recommend their usage since they have been discontinued from the project.

@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2024

Yeah, this is a quick fix as the 0.10 is approaching. We will update the solution when details of using controller-runtime as replacement are figured out.

@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2024

Let me cherry-pick this solution to make sure all release branches are aligned
/cherry-pick release-0.9

@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2024

/cherry-pick release-0.8

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #3749

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #3747 failed to apply on top of branch "release-0.8":

Applying: Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy.
Using index info to reconstruct a base tree...
M	charts/kueue/README.md
M	charts/kueue/values.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/kueue/values.yaml
Auto-merging charts/kueue/README.md
CONFLICT (content): Merge conflict in charts/kueue/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with registry.k8s.io/kubebuilder/kube-rbac-proxy.

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants