Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProvisioningRequest admission check controller #1154

Merged
merged 4 commits into from
Oct 23, 2023
Merged

ProvisioningRequest admission check controller #1154

merged 4 commits into from
Oct 23, 2023

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Sep 22, 2023 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new admission check controller ProvisioningRequestController managing the necessary ProvisioningRequests and the workloads relevant admission checks.

Which issue(s) this PR fixes:

Fixes #1136

Special notes for your reviewer:

Since the component relays heavily on the k8s API the testing is done in integration tests.
tip: run INTEGRATION_TARGET=./test/integration/controller/admissionchecks/provisioning/ GINKGO_ARGS="--coverpkg=sigs.k8s.io/kueue/pkg/controller/admissionchecks/provisioning --coverprofile=.coverage-report.out" make test-integration && go tool cover -html=bin/.coverage-report.out to check the coverage.

Does this PR introduce a user-facing change?

Integrate with Cluster Autoscaler's ProvisioningRequest via two stage admission

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2023
@netlify
Copy link

netlify bot commented Sep 22, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bcc6308
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/653675d73816380007d3fb02

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2023
@trasc trasc force-pushed the provisioning-AC branch 2 times, most recently from da7fb70 to 7d3876e Compare September 29, 2023 14:11
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2023
@trasc
Copy link
Contributor Author

trasc commented Oct 4, 2023

/test all

@trasc
Copy link
Contributor Author

trasc commented Oct 5, 2023

/test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 5, 2023
@trasc trasc changed the title Provisioning ac ProvisioningRequest admission check controller Oct 5, 2023
@trasc trasc marked this pull request as ready for review October 5, 2023 10:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@tenzen-y tenzen-y mentioned this pull request Oct 20, 2023
Closed
@tenzen-y
Copy link
Member

@trasc @alculquicondor Can we add docs for cluster autoscaler integration?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2023
@trasc
Copy link
Contributor Author

trasc commented Oct 23, 2023

@trasc @alculquicondor Can we add docs for cluster autoscaler integration?

#1242

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14b7233a2f0e7b42695d910af5690a5fbf7fdfdd

@tenzen-y
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mwielgus October 23, 2023 13:32
@tenzen-y
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b265f87f38b67ed7adb18789bd397280ce5a1e2

@k8s-ci-robot k8s-ci-robot merged commit 4313f89 into kubernetes-sigs:main Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Oct 23, 2023
@trasc trasc deleted the provisioning-AC branch October 23, 2023 13:53
@alculquicondor
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2023
@alculquicondor alculquicondor mentioned this pull request Jan 25, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kisieland kisieland kisieland left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@kerthcet kerthcet Awaiting requested review from kerthcet

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@mwielgus mwielgus

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

Support Cluster-Autoscaler's ProvisioningRequest via two-stage admission
6 participants
@trasc @k8s-ci-robot @alculquicondor @tenzen-y @mwielgus @kisieland