Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP: workload priority #1041

Merged
merged 17 commits into from
Aug 18, 2023
Merged

KEP: workload priority #1041

merged 17 commits into from
Aug 18, 2023

Conversation

Gekko0114
Copy link
Member

What type of PR is this?

/kind documentation
/kind api-change

What this PR does / why we need it:

KEP for #973

Special notes for your reviewer:

Thank you so much for your reviews.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2023
@netlify
Copy link

netlify bot commented Aug 6, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 5cb7328
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/64df23f8d7559e000894b077

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Gekko0114. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2023
@Gekko0114
Copy link
Member Author

Hi @alculquicondor,
I created a KEP based on the issue's discussion.
Could you take a look?

@tenzen-y
Copy link
Member

tenzen-y commented Aug 7, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2023
tenzen-y
tenzen-y reviewed Aug 7, 2023
View reviewed changes
tenzen-y
tenzen-y reviewed Aug 9, 2023
View reviewed changes
alculquicondor
alculquicondor reviewed Aug 10, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 13, 2023
alculquicondor
alculquicondor reviewed Aug 15, 2023
View reviewed changes
@alculquicondor
Copy link
Contributor

/label tide/merge-method-squash
/approve
I'll leave the LGTM to @tenzen-y for any final comments

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, Gekko0114

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@tenzen-y
Copy link
Member

I will review this KEP within 24 hours. Thanks for driving this KEP!

tenzen-y
tenzen-y reviewed Aug 16, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2023
@Gekko0114
Copy link
Member Author

Hi @tenzen-y , @alculquicondor
Thank you so much for your insightful comments! I learned a lot from this KEP.
I've fixed all the comments.
Could you take a look again?

tenzen-y
tenzen-y reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gekko0114 Thanks for the update! Overall LGTM!
I left a comment for a nit.

tenzen-y
tenzen-y reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5ca41f4 into kubernetes-sigs:main Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Aug 18, 2023
@Gekko0114 Gekko0114 deleted the kep branch August 18, 2023 08:40
achernevskii pushed a commit to epam/kubernetes-kueue that referenced this pull request Sep 7, 2023
@Gekko0114 @achernevskii
KEP: workload priority (kubernetes-sigs#1041)
15cf3f8 
* KEP: workload priority

* review_comment

* add_detailed_info

* update kep

* update_toc

* add integration tests

* add spaces

* modify

* not_implementing workloadPriorityClass controller

* revise

* update priorityclass discussion

* lint

* mutable

* lint

* add_xref

* toc

* fix
achernevskii pushed a commit to epam/kubernetes-kueue that referenced this pull request Sep 8, 2023
@Gekko0114 @achernevskii
KEP: workload priority (kubernetes-sigs#1041)
9ab0ecd 
* KEP: workload priority

* review_comment

* add_detailed_info

* update kep

* update_toc

* add integration tests

* add spaces

* modify

* not_implementing workloadPriorityClass controller

* revise

* update priorityclass discussion

* lint

* mutable

* lint

* add_xref

* toc

* fix
@Gekko0114 Gekko0114 mentioned this pull request Oct 2, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Gekko0114 @k8s-ci-robot @tenzen-y @alculquicondor