[GCE] Use the cluster configuration from config-test.sh #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilt after Build()
k8s-ci-robot
added
cncf-cla: yes
BenTheElder
approved these changes
Feb 27, 2021
| @@ -170,6 +162,16 @@ func (d *deployer) buildEnv() []string { | |||
| // used by the cluster/ scripts | |||
| env = append(env, fmt.Sprintf("KUBECTL_PATH=%s", d.kubectlPath)) | |||
|
|
|||
| // KUBE_CONFIG_FILE determines the file to use for setting up configuration for the cluster | |||
There was a problem hiding this comment.
this name is still so unfortunate 🙃
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set
KUBE_CONFIG_FILE=config-test.shsimilar to kubetest (https://github.com/kubernetes/test-infra/blob/d18ba04e55424699d33a47a066e4883b398c2a27/kubetest/e2e.go#L63)This is where standard configurations specifically for end-to-end test clusters using kube-up are set.
fixes: kubernetes/kubernetes#99480
xref: kubernetes/enhancements#2464
/cc @BenTheElder @liggitt