Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should have a noop deployer #45

Closed
amwat opened this issue Aug 17, 2020 · 13 comments · Fixed by #103
Closed

Should have a noop deployer #45

amwat opened this issue Aug 17, 2020 · 13 comments · Fixed by #103
Assignees
@amwat
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v0.1.0

Comments

@amwat
Copy link
Contributor

amwat commented Aug 17, 2020

Currently kubetest2 requires a deployer entrypoint.
One common use case is to run tests on an existing cluster, for which the deployer is mostly a noop.
kubetest has something similar: https://github.com/kubernetes/test-infra/blob/master/kubetest/none.go
@amwat
Copy link
Contributor Author

amwat commented Aug 17, 2020

FYI @pymander

@randomvariable
Copy link
Member

randomvariable commented Sep 8, 2020 •
edited
Loading

Interested in this as we're a potential consumer in Cluster API.

We've also inverted the deployer flow somewhat, where we have a test framework that deploys clusters using Cluster API and then runs kubetest. Probably need to think about what a CAP* deployer looks like.

kubernetes-sigs/cluster-api#3593

What's the relevant forum to discuss in terms of meetings etc?

@amwat
Copy link
Contributor Author

amwat commented Sep 8, 2020

the #sig-testing channel and meeting in the kubernetes slack is the best place (https://github.com/kubernetes-sigs/kubetest2#community-discussion-contribution-and-support)

Yup, definitely should consider a kubetest2 CAP* deployer (since that would solve the exact use case you described)

@randomvariable
Copy link
Member

Thanks, will create a new issue for tracking.

@randomvariable randomvariable mentioned this issue Sep 9, 2020
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 7, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amwat
Copy link
Contributor Author

amwat commented Mar 5, 2021

/reopen
/assign

@k8s-ci-robot k8s-ci-robot reopened this Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

@amwat: Reopened this issue.

In response to this:

/reopen
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amwat amwat mentioned this issue Mar 5, 2021
Merged
@amwat
Copy link
Contributor Author

amwat commented Mar 5, 2021

/remove-lifecycle rotten
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 5, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Jun 3, 2021
@amwat
Copy link
Contributor Author

amwat commented Jun 18, 2021

/remove-lifecycle stale
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 18, 2021
@amwat amwat added this to the v0.1.0 milestone Aug 6, 2021
@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amwat amwat

Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

[Node] Add node-e2e tester amwat/kubetest2
5 participants
@spiffxp @randomvariable @k8s-ci-robot @amwat @fejta-bot