Add port requirements docs #9969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
yankay
force-pushed
the
add-Port-Requirements
branch
from
9b5cf2d to
184d3c2
Compare
oomichi
reviewed
Apr 11, 2023
yankay
force-pushed
the
add-Port-Requirements
branch
3 times, most recently
from
60a64f6 to
c116901
Compare
MrFreezeex
reviewed
Apr 11, 2023
yankay
force-pushed
the
add-Port-Requirements
branch
from
c116901 to
27dddc6
Compare
MrFreezeex
reviewed
Apr 11, 2023
docs/port-requirements.md
Outdated
| @@ -0,0 +1,70 @@ | |||
| # Port Requirements | |||
|
|
|||
| To operate properly, KubeSpray requires some ports to be opened. If the network is configured with firewall rules, it is needed to ensure infrastructure components can communicate with each other through specific ports. | |||
There was a problem hiding this comment.
nits: KubeSpray -> Kubespray afaik?
yankay
force-pushed
the
add-Port-Requirements
branch
from
27dddc6 to
2cf05fa
Compare
|
Thanks @yankay that's a cool addition to the doc imo :D |
k8s-ci-robot
added
the
lgtm
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
In a firewall environment, there needs docs to describe the port needed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: