fix allow unsupported distribution #9904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
yankay
reviewed
Mar 20, 2023
| @@ -136,3 +136,6 @@ redhat_os_family_extensions: | |||
| - "openEuler" | |||
| - "UnionTech" | |||
| - "UniontechOS" | |||
|
|
|||
| # If enabled it will allow kubespray to attempt setup even if the distribution is not supported. For unsupported distributions this can lead to unexpected failures in some cases. | |||
| allow_unsupported_distribution_setup: false | |||
There was a problem hiding this comment.
There is a ‘allow_unsupported_distribution_setup’ variable at the https://github.com/kubernetes-sigs/kubespray/pull/9827/files
Should it be declared twice?
There was a problem hiding this comment.
Thanks for the reminder, I've put the variable declarations in all.yaml.
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
|
Thanks @ErikJiang /lgtm |
k8s-ci-robot
added
the
lgtm
floryut
approved these changes
Mar 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
I tried to set
allow_unsupported_distribution_setuptotrueto be able to deploy the cluster on an OS that is not supported by kubespray, but the actual situation still reports that the OS is not supported.I noticed that the error was related to #9827, so I updated the assertion condition.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: