fix(contrib/terraform): do not add access_ip when not wanted

[maxime1907]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The documentation says that when setting use_access_ip to 0 in terraform, private IPs will be used to transmit internal cluster traffic.
But that's not the case when only using internal IPs without floating IPs, it still wants to use the public access_ip_v4 instead of ip.
So this simple PR removes access_ip when internal IP usage is wanted.

Does this PR introduce a user-facing change?:

Remove unneeded access_ip when not wanted in terraform scripts

[k8s-ci-robot]

Hi @maxime1907. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maxime1907]

cc @oomichi @floryut

[floryut]

@maxime1907 Looks good, thank you for the PR

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, maxime1907

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• contrib/terraform/OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yankay]

/ok-to-test

[mzaian]

/close

[k8s-ci-robot]

@mzaian: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mzaian]

/reopen

[k8s-ci-robot]

@mzaian: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yankay]

Thanks @maxime1907
/lgtm

[rptaylor]

This seems to break the inventory script when upgrading to v2.22:

$ ansible-inventory --list
[WARNING]:  * Failed to parse /home/user/kubespray/cluster-dev/inventory/hosts with script plugin: Inventory script (/home/user/kubespray/cluster-dev/inventory/hosts) had
an execution error: Traceback (most recent call last):   File "/home/user/kubespray/cluster-dev/inventory/hosts", line 476, in <module>     main()   File
"/home/user/kubespray/cluster-dev/inventory/hosts", line 461, in main     output = query_list(hosts)   File "/home/user/kubespray/cluster-dev/inventory/hosts", line 392,
in query_list     for name, attrs, hostgroups in hosts:   File "/home/user/kubespray/cluster-dev/inventory/hosts", line 374, in iter_host_ips     host[1].pop('access_ip')
KeyError: 'access_ip'

It causes an error here: https://github.com/kubernetes-sigs/kubespray/blob/master/contrib/terraform/terraform.py#L372
It looks like access_ip is being popped twice now with this change? https://github.com/kubernetes-sigs/kubespray/blob/master/contrib/terraform/terraform.py#L302

Does anyone know the fix for this?