Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contrib/terraform): do not set ssh port #9828

Merged
merged 1 commit into from
Mar 2, 2023
Merged

fix(contrib/terraform): do not set ssh port #9828

merged 1 commit into from
Mar 2, 2023

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Feb 24, 2023 •
edited by floryut
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove the ssh port 22 as its already the default value

Does this PR introduce a user-facing change?:

fix(contrib/terraform): do not set ansible_ssh_port to 22

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maxime1907. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2023
@maxime1907
Copy link
Contributor Author

cc @floryut

oomichi
oomichi reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

contrib/terraform/terraform.py Outdated
import re
from collections import defaultdict
from functools import wraps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to change the order of imports here?

Copy link
Contributor Author

@maxime1907 maxime1907 Feb 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just a best practice to use this tool called isort to keep the same organized imports for everyone:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems unrelated to the purpose of this pull request, right?
If so, please have another separated pull request to keep the pull request small and simple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thanks no problem

@k8s-ci-robot k8s-ci-robot requested a review from oomichi February 27, 2023 00:08
@maxime1907
fix(contrib/terraform): do not set ssh port
4dbc53a 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
@oomichi
Copy link
Contributor

oomichi commented Feb 28, 2023

Thanks for updating

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@yankay
Copy link
Member

yankay commented Mar 2, 2023

Thanks @maxime1907
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxime1907, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 835811e into kubernetes-sigs:master Mar 2, 2023
@maxime1907 maxime1907 mentioned this pull request Mar 2, 2023
Merged
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@maxime1907 @HoKim98
fix(contrib/terraform): do not set ssh port (kubernetes-sigs#9828)
7a7b8e3 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@maxime1907 @HoKim98
fix(contrib/terraform): do not set ssh port (kubernetes-sigs#9828)
a039d84 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@maxime1907 @nolimitkun
fix(contrib/terraform): do not set ssh port (kubernetes-sigs#9828)
a33f7a6 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@maxime1907 @pedromcpedro
fix(contrib/terraform): do not set ssh port (kubernetes-sigs#9828)
b24e108 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxime1907 @k8s-ci-robot @oomichi @yankay