Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update equinox terraform code to fix kubespray CI #9702

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Jan 24, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR updates the code in contrib/terraform to align the metal code with the upstream rename to Equinix Metal and subsequent changes in the terraform provider.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This was needed in order to migrate the kubespray CI from ams1 to the am6 datacenter as requested by Equinox support.

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2023
@cristicalin cristicalin added this to the 2.22 milestone Jan 24, 2023
@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi January 24, 2023 12:28
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristicalin Thank you 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cristicalin
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2023
@cristicalin cristicalin removed this from the 2.21 milestone Jan 24, 2023
@oomichi
Copy link
Contributor

oomichi commented Jan 27, 2023

Thanks @cristicalin

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 64dbf2e into kubernetes-sigs:master Jan 27, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
* add terraform lock files to ignore list

* move contrib/terraform/metal to contrib/terraform/equinix to reflect upstream change
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
* add terraform lock files to ignore list

* move contrib/terraform/metal to contrib/terraform/equinix to reflect upstream change
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
* add terraform lock files to ignore list

* move contrib/terraform/metal to contrib/terraform/equinix to reflect upstream change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants