Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] support the download mirror for China #9396

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

yankay
Copy link
Member

@yankay yankay commented Oct 17, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:

It's really really really hard to run kubespray in china because of the GFW.
The PR is to provide a doc to support the mirror usage. It's useful to users in China.

PS. DaoCloud has a good history of sponsor the Cloud-Native OpenSource Project.

Which issue(s) this PR fixes:

Fixes

Relate:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add mirror doc to support mirror usage.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2022
@yankay yankay changed the title [Docs] suggest the download mirror for China [Docs] support the download mirror for China Oct 17, 2022
@yankay yankay force-pushed the mirror-for-china branch 2 times, most recently from 11a7884 to e677e81 Compare October 17, 2022 06:39
@liupeng0518
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@yankay yankay force-pushed the mirror-for-china branch 2 times, most recently from 5d19df0 to 77d6931 Compare October 17, 2022 06:51
@yankay
Copy link
Member Author

yankay commented Oct 18, 2022

HI @floryut @oomichi , would you please reivew the PR :-)

docs/mirror.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is drunk, force merging this one, thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, liupeng0518, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floryut,liupeng0518]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floryut floryut merged commit 1cc0f3c into kubernetes-sigs:master Oct 18, 2022
@yankay
Copy link
Member Author

yankay commented Oct 18, 2022

Thanks, @liupeng0518 @oomichi @floryut .

@floryut floryut mentioned this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants