Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calico.md to metion the ChecksumOffloadBroken=true #9388

Conversation

yankay
Copy link
Member

@yankay yankay commented Oct 13, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:

When installed in the Rocky9, there are some bugs with calico and kernel. The network is broken. The kubespray's default configuration needs to provision a healthy cluster.

So the kubespray needs to metion it the calico.md . Thanks to the @oomichi @floryut @cristicalin 's advise at the #9261

Which issue(s) this PR fixes:

Fixes #8992

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

⚠️ WARN USER ABOUT THAT

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankay Thank you, agree with this version 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@oomichi
Copy link
Contributor

oomichi commented Oct 13, 2022

Thanks for providing a good advice for users.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit e3339fe into kubernetes-sigs:master Oct 13, 2022
@andy108369
Copy link

(Thinking of whether TCP offload should be disabled by default) I am wondering how will the users find out they need to disable the TCP offload?
I discovered this issue by chance while have been debugging something else (1 second delays for SVC -> POD communication, calico configured with VXLAN.)

@floryut
Copy link
Member

floryut commented Oct 14, 2022

(Thinking of whether TCP offload should be disabled by default) I am wondering how will the users find out they need to disable the TCP offload? I discovered this issue by chance while have been debugging something else (1 second delays for SVC -> POD communication, calico configured with VXLAN.)

Noted, we'll add a warning in the next release note about this one.

@floryut floryut added the kind/network Network section in the release note label Oct 14, 2022
@andy108369
Copy link

Another point I thought to leave here, the communication between the nodes does not work at all in Linux 6.0 without this workaround (for disabling the TCP offloading).
The network packets would just hang forever, whereas with Linux 5.15 they would only delay for 1 second but go through.

salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
@yankay
Copy link
Member Author

yankay commented Dec 20, 2022

The Calico Disable VXLAN checksum offload by default at : v3.24.5, v3.25.x

projectcalico/calico#6842

@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VXLAN: bad UDP checksums
5 participants