Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry: service add clusterIP, nodePort, loadBalancer support #8291

Merged
merged 3 commits into from
Dec 15, 2021
Merged

registry: service add clusterIP, nodePort, loadBalancer support #8291

merged 3 commits into from
Dec 15, 2021

Conversation

zhengtianbao
Copy link
Member

@zhengtianbao zhengtianbao commented Dec 10, 2021 •
edited by floryut
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is the second step to implement the proposal #8221 .

User may want to expose registry Service onto an external IP address, that's outside of the cluster, now user can specify ClusterIP, NodePort or LoadBalancer as registry service type.

The default is ClusterIP, and user can specify it which from the clusterIPPool as a static cluster IP.
LoadBalancer use a cloud provider's load balancer, the cloud provider decides how it is load balanced, user may need to add some annotations to the registry service depending on the cloud Service provider.

Does this PR introduce a user-facing change?:

Add ServiceTypes support to container registry (using new variables `registry_service_type`, `registry_service_clusterIP`, `registry_service_loadBalancerIP`, `registry_service_annotations`, `registry_service_nodePort`)

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zhengtianbao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2021
cristicalin
cristicalin approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@cristicalin cristicalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengtianbao 👍

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2021
@cristicalin
Copy link
Contributor

👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2021
oomichi
oomichi reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/kubernetes-apps/registry/defaults/main.yml Outdated Show resolved Hide resolved
roles/kubernetes-apps/registry/defaults/main.yml Outdated Show resolved Hide resolved
roles/kubernetes-apps/registry/defaults/main.yml Outdated Show resolved Hide resolved
roles/kubernetes-apps/registry/defaults/main.yml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi December 15, 2021 00:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2021
oomichi
oomichi reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2021
floryut
floryut approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengtianbao 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, zhengtianbao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit aa9b845 into kubernetes-sigs:master Dec 15, 2021
nmasse-itix pushed a commit to nmasse-itix/kubespray that referenced this pull request Dec 20, 2021
@zhengtianbao @nmasse-itix
registry: service add clusterIP, nodePort, loadBalancer support (kube…
a16aa0f 
…rnetes-sigs#8291)

* registry: service add clusterIP, nodePort, loadBalancer support

* modify camelcase name to underscore

* Add registry service type compatibility check
@floryut floryut mentioned this pull request Dec 21, 2021
Closed
@zhengtianbao zhengtianbao mentioned this pull request Dec 22, 2021
Merged
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@zhengtianbao @sakuraiyuta
registry: service add clusterIP, nodePort, loadBalancer support (kube…
4aeb070 
…rnetes-sigs#8291)

* registry: service add clusterIP, nodePort, loadBalancer support

* modify camelcase name to underscore

* Add registry service type compatibility check
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
@zhengtianbao @LuckySB
registry: service add clusterIP, nodePort, loadBalancer support (kube…
0f3da36 
…rnetes-sigs#8291)

* registry: service add clusterIP, nodePort, loadBalancer support

* modify camelcase name to underscore

* Add registry service type compatibility check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@floryut floryut floryut approved these changes

@cristicalin cristicalin cristicalin approved these changes

@bozzo bozzo Awaiting requested review from bozzo

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhengtianbao @k8s-ci-robot @cristicalin @oomichi @floryut