Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix krew auto completion command not found at lower version #8185

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Fix krew auto completion command not found at lower version #8185

merged 1 commit into from
Nov 13, 2021

Conversation

zhengtianbao
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

krew version under v0.4.2 has no sub command of completion, should skip this task.

Which issue(s) this PR fixes:

Fixes #8174

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zhengtianbao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi November 11, 2021 02:01
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Fine by me to fix this asap, but checking for lower version could be better wouldn't it ?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, zhengtianbao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@oomichi
Copy link
Contributor

oomichi commented Nov 12, 2021

On Kubespray, krew version has been updated to v0.4.2 since #8168
On master branch, I guess we don't face this issue, right?

@oomichi
Copy link
Contributor

oomichi commented Nov 12, 2021

On Kubespray, krew version has been updated to v0.4.2 since #8168 On master branch, I guess we don't face this issue, right?

I might mean #8174 has been fixed already since #8168

@zhengtianbao
Copy link
Member Author

Under normal circumstances, this problem (like #8174) should not have occurred. This PR is just as a more reliable solution.

@oomichi
Copy link
Contributor

oomichi commented Nov 13, 2021

Under normal circumstances, this problem (like #8174) should not have occurred. This PR is just as a more reliable solution.

Ah, I got it.
Even if specifying v0.4.2 for krew, the binary could be v0.4.1 or older if the binary is already there in the machine due to the previous Kubespray run.
I am ok to go with this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5f14563 into kubernetes-sigs:master Nov 13, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed task Krew | Get krew completion
4 participants