Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud_provider check #8164

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Nov 5, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the preinstall check for cloud_provider option based on inventory/sample/group_vars/all/all.yml

## If set the possible values are either 'gce', 'aws', 'azure', 'openstack', 'vsphere', 'oci', or 'external'

Does this PR introduce a user-facing change?:

Fix cloud_provider check in preinstall task, allowing `oci` value (and removing deprecated ones)

This fixes the preinstall check for cloud_provider option based on
inventory/sample/group_vars/all/all.yml
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten November 5, 2021 21:56
@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit cb7c30a into kubernetes-sigs:master Nov 8, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
This fixes the preinstall check for cloud_provider option based on
inventory/sample/group_vars/all/all.yml
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
This fixes the preinstall check for cloud_provider option based on
inventory/sample/group_vars/all/all.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants