-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify runAsGroup, allow safe sysctls by default #7399
specify runAsGroup, allow safe sysctls by default #7399
Conversation
Hi @rptaylor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @rptaylor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, rptaylor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Specification of runAsGroup was left out of the kubespray PSPs . The restricted PSP did not apply any limit on runAsGroup, allowing processes to run with GID 0, which occurred by default. Depending on file permissions in container images this could allow processes to read or write files in the root group which was probably not intended to happen in the restricted PSP.
Now runAsGroup will be specified the same way as fsgroup and supplemental groups, improving security and consistency.
Also: https://kubernetes.io/docs/tasks/administer-cluster/sysctl-cluster/#podsecuritypolicy
"By default, all safe sysctls are allowed."
So it is not necessary for the restricted PSP to block all sysctls. Kubespray should follow the default behaviour of Kubernetes, allowing safe sysctls by default.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Only if people relied on the (possibly unexpected) behaviour of processes running with GID 0 but non-zero PID.