-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Openstack] Make it possible to define image using uuid #7283
[Openstack] Make it possible to define image using uuid #7283
Conversation
… openstack community images
Hi @bl0m1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bl0m1, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
… openstack community images (kubernetes-sigs#7283)
What type of PR is this?
What this PR does / why we need it:
Currently the only way to define an image is by using name. The problem when doing this is that all images needs to be set to public in openstack alternativly you need to upload the image to your tennant.
When specifying an image by uuid it can be moved to comunity (meaning not visible in horizons create server tutorial) witout having your servers recreted when re running terraform.
This PR also makes it possible to define another image to be used on masters. If no image is defined the one defined for nodes will be used.
Which issue(s) this PR fixes:
Fixes N/A
Special notes for your reviewer:
This PR does not change the standard behavior just adding the possiblity to select image by uuid and add a separate image on master nodes.
Does this PR introduce a user-facing change?: