-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable gather_facts for correctly work via bastion #7265
Disable gather_facts for correctly work via bastion #7265
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @metanovii! |
Hi @metanovii. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@metanovii Thank you for the PR, could you please sign CLA ? Would have be nice to leave the PR template and fill the fields, even if I get that everything is provided in the linked issue ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
done |
/check-cla |
f50afe9
to
bb129a1
Compare
Up! What am I doing wrong? |
Looks like the CLA isn't registered correctly with |
Yep. My mistake i missed a step with hellosign. Can I run the check CLA myself? |
All good, CLA check is now green 😄 |
|
ce174c8
to
6b6fd7c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, metanovii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@metanovii You need to rebase your branch |
f3e4a76
to
babe31a
Compare
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This request disables gathering facts, as it is not possible with bastion.
Which issue(s) this PR fixes:
Fixes #7266
Special notes for your reviewer:
Does this PR introduce a user-facing change?: