Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gather_facts for correctly work via bastion #7265

Merged

Conversation

metanovii
Copy link
Contributor

@metanovii metanovii commented Feb 8, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
This request disables gathering facts, as it is not possible with bastion.

Which issue(s) this PR fixes:
Fixes #7266

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

no

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @metanovii!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @metanovii. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2021
@metanovii metanovii mentioned this pull request Feb 8, 2021
@metanovii metanovii changed the title disable gather_facts for correctly work via bastion Disable gather_facts for correctly work via bastion Feb 8, 2021
@floryut
Copy link
Member

floryut commented Feb 9, 2021

@metanovii Thank you for the PR, could you please sign CLA ?

Would have be nice to leave the PR template and fill the fields, even if I get that everything is provided in the linked issue ;)

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2021
@metanovii
Copy link
Contributor Author

@metanovii Thank you for the PR, could you please sign CLA ?

Would have be nice to leave the PR template and fill the fields, even if I get that everything is provided in the linked issue ;)

done

@oomichi
Copy link
Contributor

oomichi commented Feb 9, 2021

/check-cla

@metanovii metanovii force-pushed the bugfix-scale-bastion branch from f50afe9 to bb129a1 Compare February 10, 2021 07:06
@metanovii
Copy link
Contributor Author

@metanovii Thank you for the PR, could you please sign CLA ?

Would have be nice to leave the PR template and fill the fields, even if I get that everything is provided in the linked issue ;)

Up! What am I doing wrong?

@floryut
Copy link
Member

floryut commented Feb 15, 2021

@metanovii Thank you for the PR, could you please sign CLA ?
Would have be nice to leave the PR template and fill the fields, even if I get that everything is provided in the linked issue ;)

Up! What am I doing wrong?

Looks like the CLA isn't registered correctly with Sergey Mikhaltsov <metanovii@gmail.com> could you recheck steps and/or follow links for help on CLA validation ?

@metanovii
Copy link
Contributor Author

metanovii commented Feb 15, 2021

@metanovii Thank you for the PR, could you please sign CLA ?
Would have be nice to leave the PR template and fill the fields, even if I get that everything is provided in the linked issue ;)

Up! What am I doing wrong?

Looks like the CLA isn't registered correctly with Sergey Mikhaltsov <metanovii@gmail.com> could you recheck steps and/or follow links for help on CLA validation ?

Yep. My mistake i missed a step with hellosign. Can I run the check CLA myself?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 15, 2021
@floryut
Copy link
Member

floryut commented Feb 15, 2021

@metanovii Thank you for the PR, could you please sign CLA ?
Would have be nice to leave the PR template and fill the fields, even if I get that everything is provided in the linked issue ;)

Up! What am I doing wrong?

Looks like the CLA isn't registered correctly with Sergey Mikhaltsov <metanovii@gmail.com> could you recheck steps and/or follow links for help on CLA validation ?

Yep. My mistake i missed a step with hellosign. Can I run the check CLA myself?

All good, CLA check is now green 😄

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 24, 2021
@champtar
Copy link
Contributor

git rebase master + git push --force please

@metanovii metanovii force-pushed the bugfix-scale-bastion branch from ce174c8 to 6b6fd7c Compare February 24, 2021 21:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
scale.yml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
scale.yml Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, metanovii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@floryut
Copy link
Member

floryut commented Mar 8, 2021

@metanovii You need to rebase your branch

@metanovii metanovii force-pushed the bugfix-scale-bastion branch from f3e4a76 to babe31a Compare March 8, 2021 21:16
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@oomichi
Copy link
Contributor

oomichi commented Mar 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit b47542b into kubernetes-sigs:master Mar 9, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 6, 2021
@floryut floryut mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scale via bastion
5 participants