Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kubernetes/master to kubernetes/control-plane #7218

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Jan 26, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is a small step to replace "master" with "control-plane" in Kubespray project.

Ref: #7157

Does this PR introduce a user-facing change?:

The role kubernetes/master has been renamed to kubernetes/control-plane.
If using the role kubernetes/master solely on previous Kubespray, it is necessary to update the specified role.

This is a small step to replace "master" with "control-plane" in
Kubespray project.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add a user facing change, as renaming a role can break some CI automation.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021
@LuckySB
Copy link
Contributor

LuckySB commented Jan 27, 2021

how about rename tags: master in playbooks ?

@oomichi
Copy link
Contributor Author

oomichi commented Jan 27, 2021

I think you can add a user facing change, as renaming a role can break some CI automation.
/approve

I see, I have updated the Does this PR introduce a user-facing change?: on this PR message.
Is it fine for us?

@oomichi
Copy link
Contributor Author

oomichi commented Jan 27, 2021

how about rename tags: master in playbooks ?

That is a nice point.
I'd like to rename the tag on separated PR to avoid a single huge PR.

@floryut
Copy link
Member

floryut commented Jan 27, 2021

how about rename tags: master in playbooks ?

That is a nice point.
I'd like to rename the tag on separated PR to avoid a single huge PR.

Agreed there is a lot of work, nice to do it step by step

@champtar
Copy link
Contributor

You can use rebase instead of squash ;)

@oomichi
Copy link
Contributor Author

oomichi commented Jan 29, 2021

You can use rebase instead of squash ;)

I am not sure I understand the above point correctly.
If that means we need to put multiple commits in a single PR, that could make it hard to explain what is Does this PR introduce a user-facing change?: for users because we would need to write multiple things into Does this PR introduce a user-facing change?: in a single PR.

@champtar
Copy link
Contributor

This is freeform text, you can put multiple lines ;)
BTW I think we should have the user impact/action needed in the commit message

@oomichi
Copy link
Contributor Author

oomichi commented Jan 29, 2021

This is freeform text, you can put multiple lines ;)

It would be hard to know which release-note lines are related to commits if a single PR contains many commits which make release-note..

BTW I think we should have the user impact/action needed in the commit message

That is different manner from current Kubernetes community way and difficult to enforce contributors do that.
To generate release-note information, the release-notes tool gathers information from PR messages, not commit messages.

@floryut
Copy link
Member

floryut commented Feb 1, 2021

/cc @EppO

@k8s-ci-robot k8s-ci-robot requested a review from EppO February 1, 2021 10:35
@EppO
Copy link
Contributor

EppO commented Feb 1, 2021

/lgtm
Thanks! I wanted to do that for a long time but never had time to do it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit c5db012 into kubernetes-sigs:master Feb 1, 2021
@oomichi oomichi deleted the replace-master branch March 2, 2021 16:51
@floryut floryut mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants