-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kubernetes/master to kubernetes/control-plane #7218
Conversation
This is a small step to replace "master" with "control-plane" in Kubespray project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can add a user facing change, as renaming a role can break some CI automation.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
how about rename |
I see, I have updated the |
That is a nice point. |
Agreed there is a lot of work, nice to do it step by step |
You can use rebase instead of squash ;) |
I am not sure I understand the above point correctly. |
This is freeform text, you can put multiple lines ;) |
It would be hard to know which release-note lines are related to commits if a single PR contains many commits which make release-note..
That is different manner from current Kubernetes community way and difficult to enforce contributors do that. |
/cc @EppO |
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a small step to replace "master" with "control-plane" in Kubespray project.
Ref: #7157
Does this PR introduce a user-facing change?: