calico: check if inventory settings match cluster settings #6969
Conversation
k8s-ci-robot
added
kind/feature
|
Hi @champtar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
champtar
force-pushed
the
calico_checks
branch
from
5207d00 to
313288c
Compare
If some settings were changed from the default but not commited into an inventory repo, we risk breaking the cluster / cause downtime, so add some extra checks Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
champtar
force-pushed
the
calico_checks
branch
from
313288c to
c22607d
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: champtar, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| - calico_pool_conf.spec.vxlanMode == calico_vxlan_mode | ||
| msg: "Your inventory doesn't match the current cluster configuration" | ||
| when: | ||
| - calico_pool_conf is defined |
There was a problem hiding this comment.
This additional check works correctly as https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/882034135
TASK [network_plugin/calico : Get Calico default-pool configuration] ***********
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/network_plugin/calico/tasks/check.yml:40
Tuesday 01 December 2020 00:10:01 +0000 (0:00:00.061) 0:12:27.143 ******
ok: [instance-1 -> None] => {"changed": false, "cmd": "calicoctl.sh get ipPool default-pool -o json", "failed_when_result": false, "msg": "[Errno 2] No such file or directory: b'calicoctl.sh': b'calicoctl.sh'", "rc": 2}
TASK [network_plugin/calico : Set calico_pool_conf] ****************************
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/network_plugin/calico/tasks/check.yml:48
Tuesday 01 December 2020 00:10:01 +0000 (0:00:00.428) 0:12:27.571 ******
TASK [network_plugin/calico : Check if inventory match current cluster configuration] ***
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/network_plugin/calico/tasks/check.yml:53
…s-sigs#6969) If some settings were changed from the default but not commited into an inventory repo, we risk breaking the cluster / cause downtime, so add some extra checks Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
If some settings were changed from the default but not commited into an inventory repo,
we risk breaking the cluster / cause downtime, so add some extra checks
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: