-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable CRI-O restart by Multus #6930
Disable CRI-O restart by Multus #6930
Conversation
Hi @basvandenbrink. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/approve
Ok the doc does indeed says this is rarely necessary, I guess we were mislead by the https://github.com/intel/multus-cni/blob/master/images/multus-daemonset-crio.yml having restart-crio=true
🤷
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: basvandenbrink, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@basvandenbrink now that #6910 is merged, could you please rebase master ? Thank you! |
/retest |
51712e0
to
7271896
Compare
Did a merge instead of a rebase. Fixed it and force pushed the changes. |
7271896
to
3e8b92d
Compare
Rebased to include pull rate limit fix. |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Currently, Multus is configured to restart CRI-O when Multus is started. According to the Multus docs, this is non-default behaviour and is rarely necessary. Furthermore, restarting CRI-O during the start of CRI-O causes errors on our side.
Error:
Quote from the docs:
https://intel.github.io/multus-cni/doc/how-to-use.html
Which issue(s) this PR fixes:
Fixes #6929
Special notes for your reviewer:
Does this PR introduce a user-facing change?: no