Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dual stack IPv4 & IPv6 networking #6859
Support dual stack IPv4 & IPv6 networking #6859
Changes from all commits
59f3715
72db549
5f5f92e
3bfc5d5
da73632
125aba3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need IP6_AUTODETECTION_METHOD (see 5 lines before)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you want it to be set to? Here are the options. It's presently using the default of
first-found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first-found
is far from ideal as soon as you have multiple interfaces and want to use CrossSubnet optionssee 7d7739e
Is there the IPv6 equivalent of
status.hostIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I could see...
Maybe adding a variable like
calico_ip6_can_reach_address:
with a default value likegoogle.com
? That way it can be overridden for the user's scenarioThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering, do we really need both IP and IP6 ? if you run dual-stack, making tunnels over IPv4 makes more sense (less overhead), so is IP6 used for dual stack ?
On bare metal I usually have the K8S traffic on an isolated VLAN
This is fine with me for a first version, I'll think more about it when I try dual stack in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not thinking of having IPv4 only host, but thinking about Calico not needing to know anyhting about the actual IPv6 config of the host. Thanks for the BGP case, in this case Calico indeed need the IPv6 info.
Has you have a dual stack cluster handy, do we have any fields with the host IPv6 in the pods status ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only IPv6 IPs seem to be in
podIPs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we get this out of the door, and then make some iterative changes to it? It's functional and fits most use cases as it is, and it would be good to get something into master for people to tweak and improve upon 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, maybe just wait for 2.15 release (soon) then we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 2.15 went on on Thursday. Is this able to be merged now, do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is netchecker checking dualstack ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with netchecker. I can drop if you don't think it needs to be there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep it, just wondering if it check dual stack, or if there is a setting to make it check, or if maybe we need an IPv4 and an IPv6 deployment. Maybe someone else knows, this is an open question not a blocker to merge.