Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install etcdctl to host when etcd deployment type is kubeadm #6857

Merged
merged 1 commit into from
Nov 4, 2020
Merged

install etcdctl to host when etcd deployment type is kubeadm #6857

merged 1 commit into from
Nov 4, 2020

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Oct 26, 2020 •
edited
Loading

  • create a wrapper script with pki options
  • supports all kubespray managed container engines

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

To enable using etcdctl with kubeadm managed etcd.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Conflicts with stale pr #6151

Tested in 3 cases (with crio):

  • no etcdctl on host
  • wrong version on host
  • same version on host

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @hafe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi October 26, 2020 06:53
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2020
@EppO
Copy link
Contributor

EppO commented Oct 27, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2020
EppO
EppO reviewed Oct 27, 2020
View reviewed changes
roles/etcdctl/tasks/main.yml
template:
src: etcdctl.sh.j2
dest: "{{ bin_dir }}/etcdctl.sh"
mode: 0755
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we only need that when using etcd_kubeadm_enabled, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I only included this role protected with that condition since I did not want to touch the etcd role

@hafe
Copy link
Contributor Author

hafe commented Oct 28, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@hafe
Copy link
Contributor Author

hafe commented Oct 28, 2020

Just realized that although it works to take an etcd snapshot it does not work in the restore case. Since then etcdctl has to be installed to host. Will update the pr

@hafe hafe force-pushed the add-etcdctl-script branch from 8b305f2 to d8a14ac Compare October 28, 2020 18:10
@hafe hafe changed the title install etcdctl script when etcd deployment type is kubeadm install etcdctl to host when etcd deployment type is kubeadm Oct 28, 2020
@hafe
Copy link
Contributor Author

hafe commented Oct 28, 2020

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@oomichi
Copy link
Contributor

oomichi commented Oct 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@hafe
install etcdctl to host when etcd deployment type is kubeadm
cdd291a 
* create a wrapper script with pki options
* supports all kubespray managed container engines
@hafe hafe force-pushed the add-etcdctl-script branch from d8a14ac to cdd291a Compare October 28, 2020 20:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@hafe
Copy link
Contributor Author

hafe commented Oct 29, 2020

/retest

oomichi
oomichi reviewed Oct 29, 2020
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@hafe
Copy link
Contributor Author

hafe commented Oct 30, 2020

/retest

1 similar comment
@hafe
Copy link
Contributor Author

hafe commented Nov 3, 2020

/retest

@mattymo
Copy link
Contributor

mattymo commented Nov 4, 2020

@hafe thanks for rewriting my PR #6151. This is a good implementation and I'll merge it.

@mattymo
Copy link
Contributor

mattymo commented Nov 4, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hafe, mattymo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@mattymo mattymo mentioned this pull request Nov 4, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit 544aa00 into kubernetes-sigs:master Nov 4, 2020
@hafe
Copy link
Contributor Author

hafe commented Nov 4, 2020

@hafe thanks for rewriting my PR #6151. This is a good implementation and I'll merge it.

Thanks!

@EppO
Copy link
Contributor

EppO commented Nov 10, 2020

Like it! good job @hafe

@floryut floryut mentioned this pull request Dec 19, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@hafe @LuckySB
install etcdctl to host when etcd deployment type is kubeadm (kuberne…
0d09dfc 
…tes-sigs#6857)

* create a wrapper script with pki options
* supports all kubespray managed container engines

Co-authored-by: Hans Feldt <hafe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@EppO EppO EppO left review comments

Assignees

@mattymo mattymo

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hafe @k8s-ci-robot @EppO @oomichi @mattymo