Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flannel image arch specific tag (#6613) #6685

Merged
merged 1 commit into from
Sep 18, 2020
Merged

flannel image arch specific tag (#6613) #6685

merged 1 commit into from
Sep 18, 2020

Conversation

Vedrillan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Pods using flannel image will be deployed with the correct arch specific tag if needed.

Which issue(s) this PR fixes:

Fixes #6613

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Vedrillan!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Vedrillan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO September 15, 2020 13:53
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2020
@floryut
Copy link
Member

floryut commented Sep 15, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2020
@floryut
Copy link
Member

floryut commented Sep 15, 2020

@Vedrillan Could you please remove issue ID in commit ? (PR ID will be added by github)

@floryut
Copy link
Member

floryut commented Sep 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Sep 18, 2020

Worth noting that this allows for clusters where all nodes have the same architecture, but will fail for clusters with mixed architectures.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, Vedrillan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit e666fe5 into kubernetes-sigs:master Sep 18, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 19, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
f7cbc45 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (21 commits)
  Make sure node_ip is set if node is in etcd group (kubernetes-sigs#6719)
  Fix order of OS CI cleanup (kubernetes-sigs#6714)
  Remove vagrant.deb from docker image (kubernetes-sigs#6717)
  Move floruyt to approver (kubernetes-sigs#6713)
  Add support for periodic CI (kubernetes-sigs#6715)
  Ignore pause from kubeadm config images list (kubernetes-sigs#6689)
  Ignore error in check mode when disabling swap (kubernetes-sigs#6703)
  flannel image arch specific tag (kubernetes-sigs#6685)
  Added missing permissions for operator. (kubernetes-sigs#6683)
  Add Kubernetes hashes 1.19.2/1.18.9/1.17.12 and set default (kubernetes-sigs#6698)
  Cleanup virsh volumes in Vagrant CI (kubernetes-sigs#6688)
  Use "kubeadm join" to join masters to control plane (kubernetes-sigs#6661)
  Remove workaround with kube_proxy_remove (kubernetes-sigs#6512)
  fix incorrect documentation of use_access_ip (kubernetes-sigs#6674)
  make metallb image repos configurable (kubernetes-sigs#6671) (kubernetes-sigs#6672)
  fix remove node (kubernetes-sigs#6666)
  Allow configuration of nodelabels in local_volume_provisioner (kubernetes-sigs#6620)
  Add support for Calico CNI host-local IPAM plugin (kubernetes-sigs#6580)
  Update third party librairies and tools (kubernetes-sigs#6669)
  Updated KataContainers version to 1.11.3 (kubernetes-sigs#6694)
  ...
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@Vedrillan @LuckySB
flannel image arch specific tag (kubernetes-sigs#6685)
1a1b0e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use arch specific tag for flannel image
4 participants
@Vedrillan @k8s-ci-robot @floryut @Miouge1