Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etcd to 3.4.13 #6658

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Update etcd to 3.4.13 #6658

merged 1 commit into from
Sep 11, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Sep 10, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
As per 1.19 dependencies etcd should now be updated to 3.4.13

Which issue(s) this PR fixes:
Link to #6654

Special notes for your reviewer:
This PR should not be merged until #6654 is in master

Does this PR introduce a user-facing change?:

Update etcd to 3.4.13

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2020
@floryut
Copy link
Member Author

floryut commented Sep 10, 2020

/hold #6654

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2020
@EppO
Copy link
Contributor

EppO commented Sep 10, 2020

should be run on top of #6654, right? we want to pass the CI with 1.19, not 1.18. better rebase it once #6654 is merged

@floryut
Copy link
Member Author

floryut commented Sep 10, 2020

should be run on top of #6654, right? we want to pass the CI with 1.19, not 1.18. better rebase it once #6654 is merged

Yup! :)

@EppO
Copy link
Contributor

EppO commented Sep 10, 2020 •
edited
Loading

packet_centos7-weave-upgrade-ha failed 3 times for the same reason.

W0910 21:53:46.738324   30901 common.go:94] WARNING: Usage of the --config flag with kubeadm config types for reconfiguring the cluster during upgrade is not recommended21:53:46.755444   30901 utils.go:69] The recommended value for "clusterDNS" in "KubeletConfiguration" is: [10.233.0.10]; the provided value is: [169.254.25.10]
W0910 21:53:50.142180   30901 configset.go:348] WARNING: kubeadm cannot validate component configs for API groups [kubelet.config.k8s.io kubeproxy.config.k8s.io]
	[WARNING CoreDNSUnsupportedPlugins]: CoreDNS cannot migrate the following plugins:
[Option "max_concurrent" in plugin "forward" is unsupported by this migration tool in 1.6.7.]

It's only a bunch of warnings though, not sure why it would make the kubeadm upgrade fail.

@EppO
Copy link
Contributor

EppO commented Sep 11, 2020

now that #6657 is merged, can you try to rebase this branch on top of it? really not convinced that's the issue here but worth trying I guess

@floryut
Copy link
Member Author

floryut commented Sep 11, 2020

now that #6657 is merged, can you try to rebase this branch on top of it? really not convinced that's the issue here but worth trying I guess

No you are right, it is something to do with coreDNS not being updated..
1.19 bundle corefile-migration that migrate coreDNS config to 1.7.0, this put a new parameter (max_concurrent) that isn't supported by lower version..

@Miouge1
Copy link
Contributor

Miouge1 commented Sep 11, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@EppO
Copy link
Contributor

EppO commented Sep 11, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@EppO
Copy link
Contributor

EppO commented Sep 11, 2020

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2fa7faa into kubernetes-sigs:master Sep 11, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 12, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
cb0b0ae 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (32 commits)
  Update api version, deprecated in 1.19 (kubernetes-sigs#6656)
  Update etcd to 3.4.13 (kubernetes-sigs#6658)
  Update dockerfile for v1.19.1 (kubernetes-sigs#6668)
  yamllint: ignore .git dir (kubernetes-sigs#6667)
  fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645)
  Remove deprecated (and removed in 1.19) flag and function --basic-auth-file (kubernetes-sigs#6655)
  Update CoreDNS to 1.7.0 (kubernetes-sigs#6657)
  Update various dependencies following 1.19 release (kubernetes-sigs#6660)
  Add Kubernetes 1.19.1 hashes and set default (kubernetes-sigs#6654)
  crio: use system default for storage driver by default (kubernetes-sigs#6637)
  Add iptables_backend to weave options (kubernetes-sigs#6639)
  Add comment clarifying network allocation and sizes (kubernetes-sigs#6607)
  Allowing resource management of metrics-server container.  Will allow fine-tuning of resource allocation and solving throttling issues. Setting defaults as per the current request & limit allocation: cpu: 43m, memory 55Mi for both limits & requests. (kubernetes-sigs#6652)
  Fix a bunch of failed quality rules (kubernetes-sigs#6646)
  Update calico to 3.16.1 (kubernetes-sigs#6644)
  NetworkManager lists must be separated by , (kubernetes-sigs#6643)
  Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633)
  Use v2.14.0 as base image for CI (kubernetes-sigs#6636)
  Cleanup v1.16 hashes (kubernetes-sigs#6635)
  Update kube_version_min_required for 2.14 release (kubernetes-sigs#6634)
  ...
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@floryut @LuckySB
Update etcd to 3.4.13 (kubernetes-sigs#6658)
0a7fd3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@EppO EppO

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@floryut @EppO @Miouge1 @k8s-ci-robot