Check node_ip is defined when removing etcd node #6603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Sep 2, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: Check node_ip is defined when removing etcd node (kubernetes-sigs#6603) Use crictl 1.19.0 for k8s 1.19.x (kubernetes-sigs#6598)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In some case, if access_ip/ip is not, remove-etcd will try to find IP by querying k8s cluster.
If the etcd node is not in the cluster this won't work and node_ip will stay empty.
This PR aimed to at least fail in this case and not output everything as if the play finish with success
Which issue(s) this PR fixes:
Fixes #6588 (partially)
Special notes for your reviewer:
This is a partial fix, we (or I) need to reproduce the setup and find an implementation that works best
Does this PR introduce a user-facing change?: