Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E306 in roles/network_plugin #6516

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Aug 10, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix E306 in roles/network_plugin

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten August 10, 2020 07:10
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2020
@Miouge1 Miouge1 force-pushed the e306-network branch 3 times, most recently from b4e5860 to 3c216b9 Compare August 11, 2020 08:46
@Miouge1 Miouge1 force-pushed the e306-network branch 2 times, most recently from 03e269a to df6a70a Compare September 1, 2020 10:07
@Miouge1 Miouge1 added this to the 2.15 milestone Sep 2, 2020
Signed-off-by: Miouge1 <maxime@root314.com>
@Miouge1 Miouge1 modified the milestones: 2.15, 2.14 Sep 3, 2020
@Miouge1 Miouge1 changed the title [WIP] Fix E306 in roles/network_plugin Fix E306 in roles/network_plugin Sep 3, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2020
@floryut
Copy link
Member

floryut commented Sep 3, 2020

way cleaner
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6245587 into kubernetes-sigs:master Sep 3, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 12, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add protectKernelDefaults option (default true) to kubelet config file (kubernetes-sigs#6611)
  Rotate kubelet server certificate. (kubernetes-sigs#6453)
  Add snapshot-controller for CSI drivers and snapshot CRDs, add a default volumesnapshotclass when running cinder CSI (kubernetes-sigs#6537)
  Calico: update crds to v1 and cr (kubernetes-sigs#6360)
  Fix E306 in roles/network_plugin (kubernetes-sigs#6516)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 15, 2021
Signed-off-by: Miouge1 <maxime@root314.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants