Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .editorconfig file #6307

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Add .editorconfig file #6307

merged 1 commit into from
Jun 29, 2020

Conversation

jseguillon
Copy link
Contributor

Editorconfig is a convenient way to ensure files are well formatted when your IDE saves files.

This PR adds a root .editorconfig file.

I tested it on few files, and it seems to be goog (only few '.sh' files are missing a newline at end of file)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jseguillon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and floryut June 22, 2020 07:18
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2020
@floryut
Copy link
Member

floryut commented Jun 22, 2020

/lgtm
/closes #5480

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@floryut
Copy link
Member

floryut commented Jun 22, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 22, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 22, 2020

/approve cancel

I found a couple of problems with this .editorconfig file:

$ docker run --rm --volume=$PWD:/check mstruebing/editorconfig-checker
.gitlab-ci/terraform.yml:
	Wrong line endings or new final newline
.gitlab-ci/vagrant.yml:
	Wrong line endings or new final newline
CNAME:
	Wrong line endings or new final newline
Dockerfile:
	10: Wrong amount of left-padding spaces(want multiple of 2)
	11: Wrong amount of left-padding spaces(want multiple of 2)
	12: Wrong amount of left-padding spaces(want multiple of 2)
	13: Wrong amount of left-padding spaces(want multiple of 2)
	14: Wrong amount of left-padding spaces(want multiple of 2)
LICENSE:
	1: Wrong amount of left-padding spaces(want multiple of 2)
	2: Wrong amount of left-padding spaces(want multiple of 2)
	5: Wrong amount of left-padding spaces(want multiple of 2)
	7: Wrong amount of left-padding spaces(want multiple of 2)
	66: Wrong amount of left-padding spaces(want multiple of 2)
	73: Wrong amount of left-padding spaces(want multiple of 2)
	89: Wrong amount of left-padding spaces(want multiple of 2)
	130: Wrong amount of left-padding spaces(want multiple of 2)
	138: Wrong amount of left-padding spaces(want multiple of 2)
	143: Wrong amount of left-padding spaces(want multiple of 2)
	153: Wrong amount of left-padding spaces(want multiple of 2)
	165: Wrong amount of left-padding spaces(want multiple of 2)
	176: Wrong amount of left-padding spaces(want multiple of 2)
	178: Wrong amount of left-padding spaces(want multiple of 2)
	189: Wrong amount of left-padding spaces(want multiple of 2)
	190: Trailing whitespace
	190: Wrong amount of left-padding spaces(want multiple of 2)
	191: Wrong amount of left-padding spaces(want multiple of 2)
	192: Wrong amount of left-padding spaces(want multiple of 2)
	193: Wrong amount of left-padding spaces(want multiple of 2)
	195: Wrong amount of left-padding spaces(want multiple of 2)
	197: Wrong amount of left-padding spaces(want multiple of 2)
	198: Wrong amount of left-padding spaces(want multiple of 2)
	199: Wrong amount of left-padding spaces(want multiple of 2)
	200: Wrong amount of left-padding spaces(want multiple of 2)
	201: Wrong amount of left-padding spaces(want multiple of 2)
Makefile:
	2: Wrong amount of left-padding spaces(want multiple of 2)
	4: Wrong amount of left-padding spaces(want multiple of 2)
	5: Wrong amount of left-padding spaces(want multiple of 2)
Vagrantfile:
	198: Trailing whitespace
_config.yml:
	Wrong line endings or new final newline
contrib/aws_inventory/kubespray-aws-inventory.py:
	72: Trailing whitespace
contrib/azurerm/.gitignore:
	Wrong line endings or new final newline
contrib/azurerm/README.md:
	27: Trailing whitespace
contrib/azurerm/group_vars/all:
	28: Wrong amount of left-padding spaces(want multiple of 2)
contrib/azurerm/roles/generate-templates/templates/availability-sets.json:
	Wrong line endings or new final newline
contrib/azurerm/roles/generate-templates/templates/bastion.json:
	Wrong line endings or new final newline
contrib/azurerm/roles/generate-templates/templates/clear-rg.json:
	Wrong line endings or new final newline
contrib/azurerm/roles/generate-templates/templates/masters.json:
	125: Wrong amount of left-padding spaces(want multiple of 2)
contrib/azurerm/roles/generate-templates/templates/minions.json:
	Wrong line endings or new final newline
contrib/azurerm/roles/generate-templates/templates/storage.json:
	Wrong line endings or new final newline
contrib/inventory_builder/inventory.py:
	47: Wrong amount of left-padding spaces(want multiple of 2)
	52: Wrong amount of left-padding spaces(want multiple of 2)
	213: Wrong amount of left-padding spaces(want multiple of 2)
	214: Wrong amount of left-padding spaces(want multiple of 2)
	304: Wrong amount of left-padding spaces(want multiple of 2)
	308: Wrong amount of left-padding spaces(want multiple of 2)
	317: Wrong amount of left-padding spaces(want multiple of 2)
	318: Wrong amount of left-padding spaces(want multiple of 2)
	323: Wrong amount of left-padding spaces(want multiple of 2)
	324: Wrong amount of left-padding spaces(want multiple of 2)
	354: Wrong amount of left-padding spaces(want multiple of 2)
	355: Wrong amount of left-padding spaces(want multiple of 2)
contrib/inventory_builder/tests/test_inventory.py:
	39: Wrong amount of left-padding spaces(want multiple of 2)
	40: Wrong amount of left-padding spaces(want multiple of 2)
	48: Wrong amount of left-padding spaces(want multiple of 2)
	58: Wrong amount of left-padding spaces(want multiple of 2)
	68: Wrong amount of left-padding spaces(want multiple of 2)
	73: Wrong amount of left-padding spaces(want multiple of 2)
	82: Wrong amount of left-padding spaces(want multiple of 2)
	93: Wrong amount of left-padding spaces(want multiple of 2)
	94: Wrong amount of left-padding spaces(want multiple of 2)
	96: Wrong amount of left-padding spaces(want multiple of 2)
	97: Wrong amount of left-padding spaces(want multiple of 2)
	106: Wrong amount of left-padding spaces(want multiple of 2)
	107: Wrong amount of left-padding spaces(want multiple of 2)
	109: Wrong amount of left-padding spaces(want multiple of 2)
	110: Wrong amount of left-padding spaces(want multiple of 2)
	114: Wrong amount of left-padding spaces(want multiple of 2)
	115: Wrong amount of left-padding spaces(want multiple of 2)
	124: Wrong amount of left-padding spaces(want multiple of 2)
	125: Wrong amount of left-padding spaces(want multiple of 2)
	127: Wrong amount of left-padding spaces(want multiple of 2)
	128: Wrong amount of left-padding spaces(want multiple of 2)
	137: Wrong amount of left-padding spaces(want multiple of 2)
	138: Wrong amount of left-padding spaces(want multiple of 2)
	140: Wrong amount of left-padding spaces(want multiple of 2)
	141: Wrong amount of left-padding spaces(want multiple of 2)
	150: Wrong amount of left-padding spaces(want multiple of 2)
	151: Wrong amount of left-padding spaces(want multiple of 2)
	153: Wrong amount of left-padding spaces(want multiple of 2)
	154: Wrong amount of left-padding spaces(want multiple of 2)
	163: Wrong amount of left-padding spaces(want multiple of 2)
	164: Wrong amount of left-padding spaces(want multiple of 2)
	166: Wrong amount of left-padding spaces(want multiple of 2)
	167: Wrong amount of left-padding spaces(want multiple of 2)
	175: Wrong amount of left-padding spaces(want multiple of 2)
	176: Wrong amount of left-padding spaces(want multiple of 2)
	179: Wrong amount of left-padding spaces(want multiple of 2)
	180: Wrong amount of left-padding spaces(want multiple of 2)
	182: Wrong amount of left-padding spaces(want multiple of 2)
	183: Wrong amount of left-padding spaces(want multiple of 2)
	191: Wrong amount of left-padding spaces(want multiple of 2)
	192: Wrong amount of left-padding spaces(want multiple of 2)
	194: Wrong amount of left-padding spaces(want multiple of 2)
	195: Wrong amount of left-padding spaces(want multiple of 2)
	197: Wrong amount of left-padding spaces(want multiple of 2)
	204: Wrong amount of left-padding spaces(want multiple of 2)
	205: Wrong amount of left-padding spaces(want multiple of 2)
	207: Wrong amount of left-padding spaces(want multiple of 2)
	208: Wrong amount of left-padding spaces(want multiple of 2)
	314: Wrong amount of left-padding spaces(want multiple of 2)
	319: Wrong amount of left-padding spaces(want multiple of 2)
	328: Wrong amount of left-padding spaces(want multiple of 2)
	339: Wrong amount of left-padding spaces(want multiple of 2)
	340: Wrong amount of left-padding spaces(want multiple of 2)
	342: Wrong amount of left-padding spaces(want multiple of 2)
	343: Wrong amount of left-padding spaces(want multiple of 2)
contrib/network-storage/glusterfs/README.md:
	42: Trailing whitespace
contrib/network-storage/glusterfs/inventory.example:
	14: Trailing whitespace
	15: Trailing whitespace
contrib/network-storage/glusterfs/roles/kubernetes-pv/ansible/templates/glusterfs-kubernetes-endpoint.json.j2:
	11: Trailing whitespace
contrib/network-storage/glusterfs/roles/kubernetes-pv/ansible/templates/glusterfs-kubernetes-pv.yml.j2:
	4: Trailing whitespace
contrib/terraform/aws/README.md:
	37: Trailing whitespace
contrib/terraform/openstack/README.md:
	428: Wrong amount of left-padding spaces(want multiple of 2)
	429: Wrong amount of left-padding spaces(want multiple of 2)
	460: Wrong amount of left-padding spaces(want multiple of 2)
	475: Wrong amount of left-padding spaces(want multiple of 2)
	476: Wrong amount of left-padding spaces(want multiple of 2)
contrib/terraform/openstack/hosts:
	80: Wrong amount of left-padding spaces(want multiple of 2)
	87: Wrong amount of left-padding spaces(want multiple of 2)
	267: Wrong amount of left-padding spaces(want multiple of 2)
	405: Wrong amount of left-padding spaces(want multiple of 2)
	406: Wrong amount of left-padding spaces(want multiple of 2)
	409: Wrong amount of left-padding spaces(want multiple of 2)
	410: Wrong amount of left-padding spaces(want multiple of 2)
	412: Wrong amount of left-padding spaces(want multiple of 2)
	413: Wrong amount of left-padding spaces(want multiple of 2)
	422: Wrong amount of left-padding spaces(want multiple of 2)
contrib/terraform/packet/README.md:
	102: Trailing whitespace
contrib/terraform/packet/hosts:
	80: Wrong amount of left-padding spaces(want multiple of 2)
	87: Wrong amount of left-padding spaces(want multiple of 2)
	267: Wrong amount of left-padding spaces(want multiple of 2)
	405: Wrong amount of left-padding spaces(want multiple of 2)
	406: Wrong amount of left-padding spaces(want multiple of 2)
	409: Wrong amount of left-padding spaces(want multiple of 2)
	410: Wrong amount of left-padding spaces(want multiple of 2)
	412: Wrong amount of left-padding spaces(want multiple of 2)
	413: Wrong amount of left-padding spaces(want multiple of 2)
	422: Wrong amount of left-padding spaces(want multiple of 2)
contrib/terraform/terraform.py:
	80: Wrong amount of left-padding spaces(want multiple of 2)
	87: Wrong amount of left-padding spaces(want multiple of 2)
	267: Wrong amount of left-padding spaces(want multiple of 2)
	405: Wrong amount of left-padding spaces(want multiple of 2)
	406: Wrong amount of left-padding spaces(want multiple of 2)
	409: Wrong amount of left-padding spaces(want multiple of 2)
	410: Wrong amount of left-padding spaces(want multiple of 2)
	412: Wrong amount of left-padding spaces(want multiple of 2)
	413: Wrong amount of left-padding spaces(want multiple of 2)
	422: Wrong amount of left-padding spaces(want multiple of 2)
contrib/vault/roles/vault/tasks/bootstrap/start_vault_temp.yml:
	9: Wrong amount of left-padding spaces(want multiple of 2)
	10: Wrong amount of left-padding spaces(want multiple of 2)
	11: Wrong amount of left-padding spaces(want multiple of 2)
	12: Wrong amount of left-padding spaces(want multiple of 2)
	13: Wrong amount of left-padding spaces(want multiple of 2)
contrib/vault/roles/vault/tasks/bootstrap/sync_secrets.yml:
	24: Wrong amount of left-padding spaces(want multiple of 2)
	25: Wrong amount of left-padding spaces(want multiple of 2)
	26: Wrong amount of left-padding spaces(want multiple of 2)
contrib/vault/roles/vault/tasks/shared/check_etcd.yml:
	28: Wrong amount of left-padding spaces(want multiple of 2)
	29: Wrong amount of left-padding spaces(want multiple of 2)
contrib/vault/roles/vault/tasks/shared/check_vault.yml:
	49: Wrong amount of left-padding spaces(want multiple of 2)
	50: Wrong amount of left-padding spaces(want multiple of 2)
contrib/vault/roles/vault/tasks/shared/create_role.yml:
	9: Wrong amount of left-padding spaces(want multiple of 2)
	10: Wrong amount of left-padding spaces(want multiple of 2)
	11: Wrong amount of left-padding spaces(want multiple of 2)
	27: Wrong amount of left-padding spaces(want multiple of 2)
	28: Wrong amount of left-padding spaces(want multiple of 2)
	29: Wrong amount of left-padding spaces(want multiple of 2)
	30: Wrong amount of left-padding spaces(want multiple of 2)
	31: Wrong amount of left-padding spaces(want multiple of 2)
	32: Wrong amount of left-padding spaces(want multiple of 2)
	33: Wrong amount of left-padding spaces(want multiple of 2)
contrib/vault/roles/vault/tasks/shared/gen_userpass.yml:
	21: Wrong amount of left-padding spaces(want multiple of 2)
	22: Wrong amount of left-padding spaces(want multiple of 2)
	24: Wrong amount of left-padding spaces(want multiple of 2)
contrib/vault/roles/vault/templates/http-proxy.conf.j2:
	Wrong line endings or new final newline
docs/_sidebar.md:
	29: Trailing whitespace
docs/calico.md:
	6: Wrong amount of left-padding spaces(want multiple of 2)
	126: Wrong amount of left-padding spaces(want multiple of 2)
docs/debian.md:
	6: Trailing whitespace
	8: Trailing whitespace
	10: Trailing whitespace
	12: Wrong amount of left-padding spaces(want multiple of 2)
	13: Wrong amount of left-padding spaces(want multiple of 2)
	14: Wrong amount of left-padding spaces(want multiple of 2)
	16: Trailing whitespace
	18: Trailing whitespace
	20: Trailing whitespace
	22: Trailing whitespace
	35: Trailing whitespace
docs/fcos.md:
	62: Wrong amount of left-padding spaces(want multiple of 2)
docs/flannel.md:
	26: Wrong amount of left-padding spaces(want multiple of 2)
	28: Wrong amount of left-padding spaces(want multiple of 2)
	46: Wrong amount of left-padding spaces(want multiple of 2)
	48: Wrong amount of left-padding spaces(want multiple of 2)
docs/gcp-pd-csi.md:
	62: Wrong amount of left-padding spaces(want multiple of 2)
	63: Wrong amount of left-padding spaces(want multiple of 2)
	64: Wrong amount of left-padding spaces(want multiple of 2)
	65: Wrong amount of left-padding spaces(want multiple of 2)
	66: Wrong amount of left-padding spaces(want multiple of 2)
	68: Wrong amount of left-padding spaces(want multiple of 2)
	69: Wrong amount of left-padding spaces(want multiple of 2)
	70: Wrong amount of left-padding spaces(want multiple of 2)
	71: Wrong amount of left-padding spaces(want multiple of 2)
docs/integration.md:
	4: Wrong amount of left-padding spaces(want multiple of 2)
	12: Wrong amount of left-padding spaces(want multiple of 2)
	13: Wrong amount of left-padding spaces(want multiple of 2)
	14: Wrong amount of left-padding spaces(want multiple of 2)
	15: Wrong amount of left-padding spaces(want multiple of 2)
	16: Wrong amount of left-padding spaces(want multiple of 2)
	26: Wrong amount of left-padding spaces(want multiple of 2)
	31: Wrong amount of left-padding spaces(want multiple of 2)
	39: Wrong amount of left-padding spaces(want multiple of 2)
	40: Wrong amount of left-padding spaces(want multiple of 2)
	41: Wrong amount of left-padding spaces(want multiple of 2)
	42: Wrong amount of left-padding spaces(want multiple of 2)
	43: Wrong amount of left-padding spaces(want multiple of 2)
	44: Wrong amount of left-padding spaces(want multiple of 2)
	50: Wrong amount of left-padding spaces(want multiple of 2)
	52: Wrong amount of left-padding spaces(want multiple of 2)
	53: Wrong amount of left-padding spaces(want multiple of 2)
	54: Wrong amount of left-padding spaces(want multiple of 2)
	55: Wrong amount of left-padding spaces(want multiple of 2)
	56: Wrong amount of left-padding spaces(want multiple of 2)
	58: Wrong amount of left-padding spaces(want multiple of 2)
	59: Wrong amount of left-padding spaces(want multiple of 2)
	61: Wrong amount of left-padding spaces(want multiple of 2)
	62: Wrong amount of left-padding spaces(want multiple of 2)
	63: Wrong amount of left-padding spaces(want multiple of 2)
	65: Wrong amount of left-padding spaces(want multiple of 2)
	66: Wrong amount of left-padding spaces(want multiple of 2)
	67: Wrong amount of left-padding spaces(want multiple of 2)
	69: Wrong amount of left-padding spaces(want multiple of 2)
	70: Wrong amount of left-padding spaces(want multiple of 2)
	71: Wrong amount of left-padding spaces(want multiple of 2)
	77: Wrong amount of left-padding spaces(want multiple of 2)
	78: Wrong amount of left-padding spaces(want multiple of 2)
	79: Wrong amount of left-padding spaces(want multiple of 2)
	80: Wrong amount of left-padding spaces(want multiple of 2)
	82: Wrong amount of left-padding spaces(want multiple of 2)
	102: Wrong amount of left-padding spaces(want multiple of 2)
	106: Wrong amount of left-padding spaces(want multiple of 2)
	114: Wrong amount of left-padding spaces(want multiple of 2)
	115: Wrong amount of left-padding spaces(want multiple of 2)
	116: Wrong amount of left-padding spaces(want multiple of 2)
docs/kubernetes-reliability.md:
	13: Wrong amount of left-padding spaces(want multiple of 2)
	16: Wrong amount of left-padding spaces(want multiple of 2)
	19: Wrong amount of left-padding spaces(want multiple of 2)
	20: Wrong amount of left-padding spaces(want multiple of 2)
docs/nodes.md:
	72: Trailing whitespace
	109: Trailing whitespace
docs/proxy.md:
	7: Wrong amount of left-padding spaces(want multiple of 2)
	8: Wrong amount of left-padding spaces(want multiple of 2)
docs/test_cases.md:
	9: Wrong amount of left-padding spaces(want multiple of 2)
docs/weave.md:
	43: Wrong amount of left-padding spaces(want multiple of 2)
	44: Wrong amount of left-padding spaces(want multiple of 2)
	45: Wrong amount of left-padding spaces(want multiple of 2)
	50: Wrong amount of left-padding spaces(want multiple of 2)
	53: Wrong amount of left-padding spaces(want multiple of 2)
inventory/sample/group_vars/etcd.yml:
	Wrong line endings or new final newline
library/kube.py:
	333: Wrong amount of left-padding spaces(want multiple of 2)
	334: Wrong amount of left-padding spaces(want multiple of 2)
roles/bootstrap-os/README.md:
	53: Wrong amount of left-padding spaces(want multiple of 2)
	54: Wrong amount of left-padding spaces(want multiple of 2)
roles/container-engine/containerd/templates/apt_preferences.d/debian_containerd.j2:
	Not all lines have the correct end of line character
roles/container-engine/containerd/vars/debian.yml:
	18: Wrong amount of left-padding spaces(want multiple of 2)
	19: Wrong amount of left-padding spaces(want multiple of 2)
	20: Wrong amount of left-padding spaces(want multiple of 2)
roles/container-engine/containerd/vars/ubuntu-amd64.yml:
	18: Wrong amount of left-padding spaces(want multiple of 2)
	19: Wrong amount of left-padding spaces(want multiple of 2)
	20: Wrong amount of left-padding spaces(want multiple of 2)
roles/container-engine/cri-o/templates/crio.conf.j2:
	97: Wrong amount of left-padding spaces(want multiple of 2)
	118: Wrong amount of left-padding spaces(want multiple of 2)
	119: Wrong amount of left-padding spaces(want multiple of 2)
	120: Wrong amount of left-padding spaces(want multiple of 2)
	121: Wrong amount of left-padding spaces(want multiple of 2)
	122: Wrong amount of left-padding spaces(want multiple of 2)
	123: Wrong amount of left-padding spaces(want multiple of 2)
	124: Wrong amount of left-padding spaces(want multiple of 2)
	125: Wrong amount of left-padding spaces(want multiple of 2)
	126: Wrong amount of left-padding spaces(want multiple of 2)
	127: Wrong amount of left-padding spaces(want multiple of 2)
	128: Wrong amount of left-padding spaces(want multiple of 2)
	151: Wrong amount of left-padding spaces(want multiple of 2)
	283: Wrong amount of left-padding spaces(want multiple of 2)
	284: Wrong amount of left-padding spaces(want multiple of 2)
roles/container-engine/docker/templates/docker-dns.conf.j2:
	Wrong line endings or new final newline
roles/container-engine/docker/templates/docker-orphan-cleanup.conf.j2:
	Wrong line endings or new final newline
roles/container-engine/docker/vars/debian.yml:
	44: Wrong amount of left-padding spaces(want multiple of 2)
	45: Wrong amount of left-padding spaces(want multiple of 2)
	46: Wrong amount of left-padding spaces(want multiple of 2)
	58: Wrong amount of left-padding spaces(want multiple of 2)
	59: Wrong amount of left-padding spaces(want multiple of 2)
	60: Wrong amount of left-padding spaces(want multiple of 2)
roles/container-engine/docker/vars/ubuntu-amd64.yml:
	44: Wrong amount of left-padding spaces(want multiple of 2)
	45: Wrong amount of left-padding spaces(want multiple of 2)
	46: Wrong amount of left-padding spaces(want multiple of 2)
	58: Wrong amount of left-padding spaces(want multiple of 2)
	59: Wrong amount of left-padding spaces(want multiple of 2)
	60: Wrong amount of left-padding spaces(want multiple of 2)
roles/container-engine/docker/vars/ubuntu-arm64.yml:
	40: Wrong amount of left-padding spaces(want multiple of 2)
	41: Wrong amount of left-padding spaces(want multiple of 2)
	42: Wrong amount of left-padding spaces(want multiple of 2)
	54: Wrong amount of left-padding spaces(want multiple of 2)
	55: Wrong amount of left-padding spaces(want multiple of 2)
	56: Wrong amount of left-padding spaces(want multiple of 2)
roles/container-engine/kata-containers/templates/configuration-qemu.toml.j2:
	98: Trailing whitespace
	100: Trailing whitespace
	101: Trailing whitespace
	177: Trailing whitespace
	205: Trailing whitespace
	212: Trailing whitespace
	215: Trailing whitespace
	230: Trailing whitespace
	232: Trailing whitespace
	245: Trailing whitespace
roles/etcd/tasks/check_certs.yml:
	33: Wrong amount of left-padding spaces(want multiple of 2)
	34: Wrong amount of left-padding spaces(want multiple of 2)
	35: Wrong amount of left-padding spaces(want multiple of 2)
	36: Wrong amount of left-padding spaces(want multiple of 2)
	37: Wrong amount of left-padding spaces(want multiple of 2)
	38: Wrong amount of left-padding spaces(want multiple of 2)
	39: Wrong amount of left-padding spaces(want multiple of 2)
	40: Wrong amount of left-padding spaces(want multiple of 2)
roles/etcd/tasks/gen_certs_script.yml:
	115: Wrong amount of left-padding spaces(want multiple of 2)
	116: Wrong amount of left-padding spaces(want multiple of 2)
roles/etcd/tasks/install_etcdctl_docker.yml:
	4: Wrong amount of left-padding spaces(want multiple of 2)
	5: Wrong amount of left-padding spaces(want multiple of 2)
	6: Wrong amount of left-padding spaces(want multiple of 2)
roles/etcd/templates/make-ssl-etcd.sh.j2:
	29: Wrong amount of left-padding spaces(want multiple of 2)
	30: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubernetes-apps/cloud_controller/oci/templates/controller-manager-config.yml.j2:
	21: Trailing whitespace
	25: Trailing whitespace
	28: Trailing whitespace
	78: Trailing whitespace
	81: Trailing whitespace
	84: Trailing whitespace
	87: Trailing whitespace
roles/kubernetes-apps/cluster_roles/templates/node-webhook-cr.yml.j2:
	Wrong line endings or new final newline
roles/kubernetes-apps/csi_driver/cinder/defaults/main.yml:
	Wrong line endings or new final newline
roles/kubernetes-apps/csi_driver/cinder/templates/cinder-csi-cloud-config.j2:
	Wrong line endings or new final newline
roles/kubernetes-apps/csi_driver/cinder/templates/cinder-csi-controllerplugin-rbac.yml.j2:
	11: Trailing whitespace
roles/kubernetes-apps/csi_driver/gcp_pd/templates/gcp-pd-csi-setup.yml.j2:
	Wrong line endings or new final newline
roles/kubernetes-apps/external_provisioner/local_path_provisioner/defaults/main.yml:
	Wrong line endings or new final newline
roles/kubernetes-apps/external_provisioner/local_path_provisioner/templates/local-path-storage-ns.yml.j2:
	Wrong line endings or new final newline
roles/kubernetes-apps/external_provisioner/local_path_provisioner/templates/local-path-storage-sa.yml.j2:
	Wrong line endings or new final newline
roles/kubernetes-apps/external_provisioner/local_volume_provisioner/README.md:
	20: Wrong amount of left-padding spaces(want multiple of 2)
	21: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubernetes-apps/helm/templates/helm-container.j2:
	10: Trailing whitespace
roles/kubernetes-apps/ingress_controller/alb_ingress_controller/OWNERS:
	Wrong line endings or new final newline
roles/kubernetes-apps/ingress_controller/alb_ingress_controller/templates/alb-ingress-clusterrole.yml.j2:
	Wrong line endings or new final newline
roles/kubernetes-apps/ingress_controller/alb_ingress_controller/templates/alb-ingress-deploy.yml.j2:
	Wrong line endings or new final newline
	36: Trailing whitespace
	45: Trailing whitespace
roles/kubernetes-apps/ingress_controller/cert_manager/templates/crd-certificate.yml.j2:
	23: Trailing whitespace
roles/kubernetes-apps/network_plugin/kube-router/OWNERS:
	Wrong line endings or new final newline
roles/kubernetes/master/templates/kubeadm-config.v1beta2.yaml.j2:
	325: Wrong amount of left-padding spaces(want multiple of 2)
	326: Wrong amount of left-padding spaces(want multiple of 2)
	327: Wrong amount of left-padding spaces(want multiple of 2)
	328: Wrong amount of left-padding spaces(want multiple of 2)
	329: Wrong amount of left-padding spaces(want multiple of 2)
	333: Wrong amount of left-padding spaces(want multiple of 2)
	334: Wrong amount of left-padding spaces(want multiple of 2)
	335: Wrong amount of left-padding spaces(want multiple of 2)
	336: Wrong amount of left-padding spaces(want multiple of 2)
	341: Wrong amount of left-padding spaces(want multiple of 2)
	342: Wrong amount of left-padding spaces(want multiple of 2)
	343: Wrong amount of left-padding spaces(want multiple of 2)
	344: Wrong amount of left-padding spaces(want multiple of 2)
	346: Wrong amount of left-padding spaces(want multiple of 2)
	347: Wrong amount of left-padding spaces(want multiple of 2)
	348: Wrong amount of left-padding spaces(want multiple of 2)
	349: Wrong amount of left-padding spaces(want multiple of 2)
	350: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubernetes/master/templates/webhook-token-auth-config.yaml.j2:
	Wrong line endings or new final newline
roles/kubernetes/node-label/tasks/main.yml:
	43: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubernetes/node/templates/kubelet.service.j2:
	15: Wrong amount of left-padding spaces(want multiple of 2)
	16: Wrong amount of left-padding spaces(want multiple of 2)
	17: Wrong amount of left-padding spaces(want multiple of 2)
	18: Wrong amount of left-padding spaces(want multiple of 2)
	19: Wrong amount of left-padding spaces(want multiple of 2)
	20: Wrong amount of left-padding spaces(want multiple of 2)
	21: Wrong amount of left-padding spaces(want multiple of 2)
	22: Wrong amount of left-padding spaces(want multiple of 2)
	23: Wrong amount of left-padding spaces(want multiple of 2)
	24: Wrong amount of left-padding spaces(want multiple of 2)
	25: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubernetes/preinstall/gen-gitinfos.sh:
	54: Wrong amount of left-padding spaces(want multiple of 2)
	60: Wrong amount of left-padding spaces(want multiple of 2)
	61: Wrong amount of left-padding spaces(want multiple of 2)
	66: Wrong amount of left-padding spaces(want multiple of 2)
	67: Wrong amount of left-padding spaces(want multiple of 2)
	71: Wrong amount of left-padding spaces(want multiple of 2)
	72: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubernetes/preinstall/tasks/0090-etchosts.yml:
	46: Wrong amount of left-padding spaces(want multiple of 2)
	47: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubernetes/tokens/tasks/check-tokens.yml:
	30: Wrong amount of left-padding spaces(want multiple of 2)
	31: Wrong amount of left-padding spaces(want multiple of 2)
	32: Wrong amount of left-padding spaces(want multiple of 2)
roles/kubespray-defaults/defaults/main.yaml:
	436: Wrong amount of left-padding spaces(want multiple of 2)
	438: Wrong amount of left-padding spaces(want multiple of 2)
	440: Wrong amount of left-padding spaces(want multiple of 2)
	442: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/calico/files/make-ssl-typha.sh:
	30: Wrong amount of left-padding spaces(want multiple of 2)
	31: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/calico/tasks/install.yml:
	201: Wrong amount of left-padding spaces(want multiple of 2)
	204: Wrong amount of left-padding spaces(want multiple of 2)
	205: Wrong amount of left-padding spaces(want multiple of 2)
	223: Wrong amount of left-padding spaces(want multiple of 2)
	226: Wrong amount of left-padding spaces(want multiple of 2)
	227: Wrong amount of left-padding spaces(want multiple of 2)
	245: Wrong amount of left-padding spaces(want multiple of 2)
	248: Wrong amount of left-padding spaces(want multiple of 2)
	249: Wrong amount of left-padding spaces(want multiple of 2)
	318: Wrong amount of left-padding spaces(want multiple of 2)
	321: Wrong amount of left-padding spaces(want multiple of 2)
	322: Wrong amount of left-padding spaces(want multiple of 2)
	323: Wrong amount of left-padding spaces(want multiple of 2)
	324: Wrong amount of left-padding spaces(want multiple of 2)
	342: Wrong amount of left-padding spaces(want multiple of 2)
	345: Wrong amount of left-padding spaces(want multiple of 2)
	346: Wrong amount of left-padding spaces(want multiple of 2)
	347: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/calico/templates/calico-node.yml.j2:
	371: Wrong amount of left-padding spaces(want multiple of 2)
	372: Wrong amount of left-padding spaces(want multiple of 2)
	373: Wrong amount of left-padding spaces(want multiple of 2)
	374: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/calico/templates/calico-typha.yml.j2:
	148: Wrong amount of left-padding spaces(want multiple of 2)
	149: Wrong amount of left-padding spaces(want multiple of 2)
	150: Wrong amount of left-padding spaces(want multiple of 2)
	151: Wrong amount of left-padding spaces(want multiple of 2)
	156: Wrong amount of left-padding spaces(want multiple of 2)
	157: Wrong amount of left-padding spaces(want multiple of 2)
	158: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/calico/templates/kdd-crds.yml.j2:
	6: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/canal/templates/cni-canal.conflist.j2:
	9: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/files/contiv-cleanup.sh:
	7: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/tasks/main.yml:
	149: Wrong amount of left-padding spaces(want multiple of 2)
	150: Wrong amount of left-padding spaces(want multiple of 2)
	151: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/templates/contiv-cleanup.yml.j2:
	32: Wrong amount of left-padding spaces(want multiple of 2)
	33: Wrong amount of left-padding spaces(want multiple of 2)
	34: Wrong amount of left-padding spaces(want multiple of 2)
	35: Wrong amount of left-padding spaces(want multiple of 2)
	36: Wrong amount of left-padding spaces(want multiple of 2)
	37: Wrong amount of left-padding spaces(want multiple of 2)
	38: Wrong amount of left-padding spaces(want multiple of 2)
	39: Wrong amount of left-padding spaces(want multiple of 2)
	40: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/templates/contiv-config.yml.j2:
	25: Wrong amount of left-padding spaces(want multiple of 2)
	26: Wrong amount of left-padding spaces(want multiple of 2)
	27: Wrong amount of left-padding spaces(want multiple of 2)
	28: Wrong amount of left-padding spaces(want multiple of 2)
	29: Wrong amount of left-padding spaces(want multiple of 2)
	30: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/templates/contiv-etcd-proxy.yml.j2:
	23: Wrong amount of left-padding spaces(want multiple of 2)
	24: Wrong amount of left-padding spaces(want multiple of 2)
	25: Wrong amount of left-padding spaces(want multiple of 2)
	26: Wrong amount of left-padding spaces(want multiple of 2)
	27: Wrong amount of left-padding spaces(want multiple of 2)
	28: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/templates/contiv-netplugin.yml.j2:
	81: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/templates/contiv-ovs.yml.j2:
	60: Wrong amount of left-padding spaces(want multiple of 2)
	61: Wrong amount of left-padding spaces(want multiple of 2)
	62: Wrong amount of left-padding spaces(want multiple of 2)
	63: Wrong amount of left-padding spaces(want multiple of 2)
	64: Wrong amount of left-padding spaces(want multiple of 2)
	65: Wrong amount of left-padding spaces(want multiple of 2)
	66: Wrong amount of left-padding spaces(want multiple of 2)
	67: Wrong amount of left-padding spaces(want multiple of 2)
	68: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/contiv/templates/generate-certificate.sh.j2:
	11: Wrong amount of left-padding spaces(want multiple of 2)
	21: Wrong amount of left-padding spaces(want multiple of 2)
	22: Wrong amount of left-padding spaces(want multiple of 2)
	23: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/kube-ovn/defaults/main.yml:
	Wrong line endings or new final newline
roles/network_plugin/kube-ovn/templates/cni-kube-ovn-crd.yml.j2:
	Wrong line endings or new final newline
roles/network_plugin/kube-ovn/templates/cni-ovn.yml.j2:
	Wrong line endings or new final newline
roles/network_plugin/kube-router/OWNERS:
	Wrong line endings or new final newline
roles/network_plugin/kube-router/defaults/main.yml:
	Wrong line endings or new final newline
roles/network_plugin/kube-router/templates/cni-conf.json.j2:
	2: Wrong amount of left-padding spaces(want multiple of 2)
	3: Wrong amount of left-padding spaces(want multiple of 2)
	4: Wrong amount of left-padding spaces(want multiple of 2)
	6: Wrong amount of left-padding spaces(want multiple of 2)
	7: Wrong amount of left-padding spaces(want multiple of 2)
	8: Wrong amount of left-padding spaces(want multiple of 2)
	9: Wrong amount of left-padding spaces(want multiple of 2)
	13: Wrong amount of left-padding spaces(want multiple of 2)
	18: Wrong amount of left-padding spaces(want multiple of 2)
	21: Wrong amount of left-padding spaces(want multiple of 2)
	22: Wrong amount of left-padding spaces(want multiple of 2)
	24: Wrong amount of left-padding spaces(want multiple of 2)
	26: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/macvlan/files/ifdown-macvlan:
	5: Trailing whitespace
	10: Trailing whitespace
	15: Trailing whitespace
	35: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/macvlan/files/ifup-macvlan:
	5: Trailing whitespace
	10: Trailing whitespace
	15: Trailing whitespace
	35: Wrong amount of left-padding spaces(want multiple of 2)
	39: Wrong amount of left-padding spaces(want multiple of 2)
	40: Wrong amount of left-padding spaces(want multiple of 2)
	41: Wrong amount of left-padding spaces(want multiple of 2)
roles/network_plugin/multus/files/multus-clusterrole.yml:
	Wrong line endings or new final newline
roles/upgrade/pre-upgrade/tasks/main.yml:
	6: Wrong amount of left-padding spaces(want multiple of 2)
	7: Wrong amount of left-padding spaces(want multiple of 2)
	17: Wrong amount of left-padding spaces(want multiple of 2)
	18: Wrong amount of left-padding spaces(want multiple of 2)
test-infra/image-builder/Makefile:
	2: Wrong amount of left-padding spaces(want multiple of 2)
test-infra/image-builder/OWNERS:
	5: Trailing whitespace
	8: Trailing whitespace
test-infra/image-builder/roles/kubevirt-images/defaults/main.yml:
	Wrong line endings or new final newline
tests/Makefile:
	Wrong line endings or new final newline
	4: Wrong amount of left-padding spaces(want multiple of 2)
	5: Wrong amount of left-padding spaces(want multiple of 2)
	6: Wrong amount of left-padding spaces(want multiple of 2)
	9: Wrong amount of left-padding spaces(want multiple of 2)
	10: Wrong amount of left-padding spaces(want multiple of 2)
	13: Wrong amount of left-padding spaces(want multiple of 2)
	16: Wrong amount of left-padding spaces(want multiple of 2)
	17: Wrong amount of left-padding spaces(want multiple of 2)
	20: Wrong amount of left-padding spaces(want multiple of 2)
	23: Wrong amount of left-padding spaces(want multiple of 2)
	26: Wrong amount of left-padding spaces(want multiple of 2)
	27: Wrong amount of left-padding spaces(want multiple of 2)
	28: Wrong amount of left-padding spaces(want multiple of 2)
	29: Wrong amount of left-padding spaces(want multiple of 2)
	30: Wrong amount of left-padding spaces(want multiple of 2)
	31: Wrong amount of left-padding spaces(want multiple of 2)
	32: Wrong amount of left-padding spaces(want multiple of 2)
	33: Wrong amount of left-padding spaces(want multiple of 2)
	34: Wrong amount of left-padding spaces(want multiple of 2)
	38: Wrong amount of left-padding spaces(want multiple of 2)
	39: Wrong amount of left-padding spaces(want multiple of 2)
	40: Wrong amount of left-padding spaces(want multiple of 2)
	41: Wrong amount of left-padding spaces(want multiple of 2)
	42: Wrong amount of left-padding spaces(want multiple of 2)
	43: Wrong amount of left-padding spaces(want multiple of 2)
	44: Wrong amount of left-padding spaces(want multiple of 2)
	45: Wrong amount of left-padding spaces(want multiple of 2)
	48: Wrong amount of left-padding spaces(want multiple of 2)
	49: Wrong amount of left-padding spaces(want multiple of 2)
	50: Wrong amount of left-padding spaces(want multiple of 2)
	51: Wrong amount of left-padding spaces(want multiple of 2)
	52: Wrong amount of left-padding spaces(want multiple of 2)
	55: Wrong amount of left-padding spaces(want multiple of 2)
	56: Wrong amount of left-padding spaces(want multiple of 2)
	57: Wrong amount of left-padding spaces(want multiple of 2)
	58: Wrong amount of left-padding spaces(want multiple of 2)
	59: Wrong amount of left-padding spaces(want multiple of 2)
	60: Wrong amount of left-padding spaces(want multiple of 2)
	63: Wrong amount of left-padding spaces(want multiple of 2)
	64: Wrong amount of left-padding spaces(want multiple of 2)
	65: Wrong amount of left-padding spaces(want multiple of 2)
	66: Wrong amount of left-padding spaces(want multiple of 2)
	67: Wrong amount of left-padding spaces(want multiple of 2)
	70: Wrong amount of left-padding spaces(want multiple of 2)
	71: Wrong amount of left-padding spaces(want multiple of 2)
	72: Wrong amount of left-padding spaces(want multiple of 2)
	73: Wrong amount of left-padding spaces(want multiple of 2)
	74: Wrong amount of left-padding spaces(want multiple of 2)
	77: Wrong amount of left-padding spaces(want multiple of 2)
	78: Wrong amount of left-padding spaces(want multiple of 2)
	79: Wrong amount of left-padding spaces(want multiple of 2)
	82: Wrong amount of left-padding spaces(want multiple of 2)
tests/cloud_playbooks/templates/gcs_life.json.j2:
	2: Wrong amount of left-padding spaces(want multiple of 2)
	3: Wrong amount of left-padding spaces(want multiple of 2)
	4: Wrong amount of left-padding spaces(want multiple of 2)
	5: Wrong amount of left-padding spaces(want multiple of 2)
	6: Wrong amount of left-padding spaces(want multiple of 2)
	7: Wrong amount of left-padding spaces(want multiple of 2)
	8: Wrong amount of left-padding spaces(want multiple of 2)
tests/files/packet_centos7-weave-upgrade-ha.yml:
	Wrong line endings or new final newline
tests/files/packet_centos8-kube-ovn.yml:
	Wrong line endings or new final newline
tests/files/packet_debian10-containerd.yml:
	Wrong line endings or new final newline
tests/files/tf-elastx_ubuntu18-calico.yml:
	Wrong line endings or new final newline
tests/files/vagrant_ubuntu18-flannel.rb:
	Wrong line endings or new final newline
tests/files/vagrant_ubuntu18-flannel.yml:
	Wrong line endings or new final newline
tests/files/vagrant_ubuntu20-flannel.rb:
	Wrong line endings or new final newline
tests/files/vagrant_ubuntu20-flannel.yml:
	Wrong line endings or new final newline
tests/scripts/md-table/main.py:
	Wrong line endings or new final newline
	30: Trailing whitespace
tests/scripts/md-table/requirements.txt:
	Wrong line endings or new final newline
tests/scripts/md-table/table.md.j2:
	Wrong line endings or new final newline
	3: Trailing whitespace
tests/scripts/md-table/test.sh:
	Wrong line endings or new final newline
tests/scripts/molecule_run.sh:
	Wrong line endings or new final newline
tests/scripts/vagrant_clean.sh:
	Wrong line endings or new final newline
tests/shebang-unit:
	251: Wrong amount of left-padding spaces(want multiple of 2)
	1026: Wrong amount of left-padding spaces(want multiple of 2)
	1094: Wrong amount of left-padding spaces(want multiple of 2)
tests/testcases/010_check-apiserver.yml:
	Wrong line endings or new final newline
tests/testcases/015_check-nodes-ready.yml:
	Wrong line endings or new final newline
tests/testcases/030_check-network.yml:
	54: Wrong amount of left-padding spaces(want multiple of 2)
	60: Wrong amount of left-padding spaces(want multiple of 2)

604 errors found

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@jseguillon
Copy link
Contributor Author

Oh great did not know there is a tool to check this, only tested on few samples ...

Best thing would probably be I also commit changes on those files so they conform to editor config.

@Miouge1
Copy link
Contributor

Miouge1 commented Jun 22, 2020

@jseguillon I suppose that Makefile will need a separate entry since they are tav separated instead of space. I am not aware of any other exception, but other things might come up

@jseguillon
Copy link
Contributor Author

Sure. I will take care of exceptions :)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2020
@jseguillon jseguillon force-pushed the feat-editorconfig branch 3 times, most recently from b8895e3 to f998e71 Compare June 22, 2020 21:28
@jseguillon
Copy link
Contributor Author

I made the job on a small subset as a beginning : yaml and jinja2 yamls.

Now ok with mstruebing/editorconfig-checker (maybe I should add it in GitlabCI ?)

No tested yet. Maybe dangerous to merge unless CI does cover all the scope of modified content.
Especially some changes on contiv plugin templates should be reviewed with cautious.

Non included files summary :

CNAME:
LICENSE:
Makefile:
Vagrantfile:
contrib/aws_inventory/kubespray-aws-inventory.py:
contrib/azurerm/.gitignore:
contrib/azurerm/README.md:
contrib/azurerm/group_vars/all:
contrib/azurerm/roles/generate-templates/templates/availability-sets.json:
contrib/azurerm/roles/generate-templates/templates/bastion.json:
contrib/azurerm/roles/generate-templates/templates/clear-rg.json:
contrib/azurerm/roles/generate-templates/templates/masters.json:
contrib/azurerm/roles/generate-templates/templates/minions.json:
contrib/azurerm/roles/generate-templates/templates/storage.json:
contrib/inventory_builder/inventory.py:
contrib/inventory_builder/tests/test_inventory.py:
contrib/metallb/library:
contrib/network-storage/glusterfs/README.md:
contrib/network-storage/glusterfs/group_vars:
contrib/network-storage/glusterfs/inventory.example:
contrib/network-storage/glusterfs/roles/bootstrap-os:
contrib/terraform/aws/README.md:
contrib/terraform/aws/sample-inventory/group_vars:
contrib/terraform/group_vars:
contrib/terraform/openstack/README.md:
contrib/terraform/openstack/hosts:
contrib/terraform/openstack/sample-inventory/group_vars:
contrib/terraform/packet/README.md:
contrib/terraform/packet/hosts:
contrib/terraform/packet/sample-inventory/group_vars:
contrib/terraform/terraform.py:
docs/_sidebar.md:
docs/calico.md:
docs/debian.md:
docs/fcos.md:
docs/flannel.md:
docs/gcp-pd-csi.md:
docs/integration.md:
docs/kubernetes-reliability.md:
docs/nodes.md:
docs/proxy.md:
docs/test_cases.md:
docs/weave.md:
extra_playbooks/inventory:
extra_playbooks/roles:
inventory/local/group_vars:
library/kube.py:
roles/bootstrap-os/README.md:
roles/container-engine/cri-o/templates/crio.conf.j2:
roles/container-engine/docker/templates/docker-dns.conf.j2:
roles/container-engine/docker/templates/docker-orphan-cleanup.conf.j2:
roles/etcd/templates/make-ssl-etcd.sh.j2:
roles/kubernetes-apps/csi_driver/cinder/templates/cinder-csi-cloud-config.j2:
roles/kubernetes-apps/external_provisioner/local_volume_provisioner/README.md:
roles/kubernetes-apps/helm/templates/helm-container.j2:
roles/kubernetes-apps/ingress_controller/alb_ingress_controller/OWNERS:
roles/kubernetes-apps/network_plugin/kube-router/OWNERS:
roles/kubernetes/node/templates/kubelet.service.j2:
roles/kubernetes/preinstall/gen-gitinfos.sh:
roles/network_plugin/calico/files/make-ssl-typha.sh:
roles/network_plugin/canal/templates/cni-canal.conflist.j2:
roles/network_plugin/contiv/files/contiv-cleanup.sh:
roles/network_plugin/contiv/templates/generate-certificate.sh.j2:
roles/network_plugin/kube-router/OWNERS:
roles/network_plugin/kube-router/templates/cni-conf.json.j2:
roles/network_plugin/macvlan/files/ifdown-macvlan:
roles/network_plugin/macvlan/files/ifup-macvlan:
test-infra/image-builder/Makefile:
test-infra/image-builder/OWNERS:
tests/Makefile:
tests/cloud_playbooks/templates/gcs_life.json.j2:
tests/files/vagrant_ubuntu18-flannel.rb:
tests/files/vagrant_ubuntu20-flannel.rb:
tests/scripts/md-table/main.py:
tests/scripts/md-table/requirements.txt:
tests/scripts/md-table/table.md.j2:
tests/scripts/md-table/test.sh:
tests/scripts/molecule_run.sh:
tests/scripts/vagrant_clean.sh:
tests/shebang-unit:

@Miouge1
Copy link
Contributor

Miouge1 commented Jun 24, 2020

@jseguillon wow!

I think it makes sense to do this in stages, like YAML and Dockerfile in this PR, maybe shell scripts in another etc...

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jseguillon, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@jseguillon
Copy link
Contributor Author

@Miouge1 : do you think you can merge this one before I open new PR for other formats or prefer I add more into this one ? Seems to me it would be easier to approve this one first but its up to you :)

@floryut
Copy link
Member

floryut commented Jun 29, 2020

Yup let's merge
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@floryut floryut mentioned this pull request Jun 29, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit 4c1e0b1 into kubernetes-sigs:master Jun 29, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jun 30, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
9edd12d 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (22 commits)
  Remove runtime-config from kubeadm if empty (kubernetes-sigs#6311)
  Update deprecated api (kubernetes-sigs#6245)
  Update kube-router to 1.0.0 (kubernetes-sigs#6211)
  Fix kubelet cgroup driver detection for crio (kubernetes-sigs#6331)
  Update hashes and set default version to 1.18.5 (kubernetes-sigs#6335)
  Change MetalLB to one of addons (kubernetes-sigs#6238)
  Update calico to 1.15.0 + minor update to kube-ovn/weave (kubernetes-sigs#6306)
  Add .editorconfig file (kubernetes-sigs#6307)
  Use NetworkManager to manage resolv.conf in FedoraCoreOS (kubernetes-sigs#6291)
  Add USE_REAL_HOSTNAME to inventory.py (kubernetes-sigs#6293)
  Cleanup OpenStack network things (kubernetes-sigs#6283)
  Add support for dns_etchosts (kubernetes-sigs#6236)
  kube_encryption_resources must be output as yaml (kubernetes-sigs#6309)
  Gather ansible_default_ipv4 for specific groups (kubernetes-sigs#6318)
  added azure_cloud parameter to Azure's cloud_config (kubernetes-sigs#6321)
  Fix some doc links (kubernetes-sigs#6328)
  Use `connection: local` when `delegate_to: localhost` (kubernetes-sigs#6322)
  Add /dev volume (kubernetes-sigs#6319)
  Update cilium to 1.8.0 (kubernetes-sigs#6314)
  fix use of ansible tags (kubernetes-sigs#6316)
  ...
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 6, 2020
@jseguillon @LuckySB
Add .editorconfig file (kubernetes-sigs#6307)
5826e3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@floryut floryut Awaiting requested review from floryut

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jseguillon @k8s-ci-robot @floryut @Miouge1