Patch Calico V3.14.0 roles, missing CR and CRD for calico_kube_controller #6276

nurekage · 2020-06-16T12:34:57Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Ensures existence of CRD "kubecontrollersconfigurations" and defines rbac for this CR

Which issue(s) this PR fixes:

Fixes #6275

Special notes for your reviewer:

We patched live didn't test kubespray deploy (issue came after a gracefull upgrade)

Does this PR introduce a user-facing change?:
No idea

Add kubecontrollersconfigurations CRD in kdd-crds.yml in roles/network_plugins/calico/templates and corresponding CR in roles/kubernetes_apps/policy_controller/calico/templates/calico_kube_cr.yml
Also defined missing "hostendpoints" CR in roles/kubernetes_apps/policy_controller/calico/templates/calico_kube_cr.yml

Source https://docs.projectcalico.org/manifests/calico.yaml

k8s-ci-robot · 2020-06-16T12:35:00Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-06-16T12:35:05Z

Welcome @nurekage!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-06-16T12:35:05Z

Hi @nurekage. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

floryut · 2020-06-16T12:46:29Z

@nurekage Thank you for the PR, Can you sign CLA ?
/ok-to-test

roles/network_plugin/calico/templates/kdd-crds.yml.j2

hafe · 2020-06-17T04:42:48Z

solves #6275, same problem

nurekage · 2020-06-24T08:05:54Z

roles/network_plugin/calico/templates/kdd-crds.yml.j2

@@ -212,7 +212,11 @@ spec:
 {% endif %}
 {% if calico_version is version('v3.14.0', '>=') %}
 ---
+{% if kube_version is version('1.19.0', '>=') %}
+apiVersion: apiextensions.k8s.io/v1


I tried this but doesn't seem to pass
As said 1.19 isn't out and v1beta1 won't be going away that fast.

Go ahead with your change, I'll rebase and package everything with my crd PR when kube-ovn release their CRD under v1

nurekage · 2020-06-24T09:45:42Z

/assign @Atoms

floryut · 2020-06-25T08:28:42Z

On a side note, you can find the CRD v1 here

hafe · 2020-06-25T16:23:09Z

I guess you should remove the last two commits and keep the first one.

floryut · 2020-06-29T12:30:40Z

@nurekage The latest CI error you have is due to your branch being outdated :/
Could you rebase master please ?

hafe · 2020-07-01T15:19:33Z

See #6360

LuckySB · 2020-07-01T15:32:31Z

/approve

k8s-ci-robot · 2020-07-01T15:32:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB, nurekage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [LuckySB]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

floryut · 2020-07-01T15:35:57Z

/lgtm

@hafe will update this one if need be

* 'master' of https://github.com/kubernetes-sigs/kubespray: Patch Calico for V3.14.0 missing CR and CRD (kubernetes-sigs#6276) Explicitly set ETCDCTL_API and use ETCDCTL_ENDPOINTS (kubernetes-sigs#6327) Add additional metadata configuration options to external Openstack CCM (kubernetes-sigs#6338) (kubernetes-sigs#6339)

k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 16, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2020

k8s-ci-robot requested review from bozzo and holmsten June 16, 2020 12:35

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2020

nurekage force-pushed the master branch from b1473f3 to 1c204f1 Compare June 16, 2020 13:14

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 16, 2020

floryut reviewed Jun 16, 2020

View reviewed changes

roles/network_plugin/calico/templates/kdd-crds.yml.j2 Show resolved Hide resolved

nurekage commented Jun 24, 2020

View reviewed changes

k8s-ci-robot assigned Atoms Jun 24, 2020

nurekage force-pushed the master branch from f35b3b9 to 1c204f1 Compare June 29, 2020 07:16

Patch Calico for V3.14.0 missing CR and CRD

79fcc0b

nurekage force-pushed the master branch from 1c204f1 to 79fcc0b Compare June 29, 2020 12:45

floryut mentioned this pull request Jul 1, 2020

Update calico crds and cr #6360

Merged

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020

k8s-ci-robot assigned floryut Jul 1, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020

k8s-ci-robot merged commit 017df71 into kubernetes-sigs:master Jul 1, 2020

LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020

Patch Calico for V3.14.0 missing CR and CRD (kubernetes-sigs#6276)

1ccbbf7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch Calico V3.14.0 roles, missing CR and CRD for calico_kube_controller #6276

Patch Calico V3.14.0 roles, missing CR and CRD for calico_kube_controller #6276

nurekage commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

floryut commented Jun 16, 2020

hafe commented Jun 17, 2020

nurekage Jun 24, 2020 •

edited

Loading

floryut Jun 24, 2020

nurekage commented Jun 24, 2020

floryut commented Jun 25, 2020

hafe commented Jun 25, 2020

floryut commented Jun 29, 2020

hafe commented Jul 1, 2020

LuckySB commented Jul 1, 2020

k8s-ci-robot commented Jul 1, 2020

floryut commented Jul 1, 2020

Patch Calico V3.14.0 roles, missing CR and CRD for calico_kube_controller #6276

Patch Calico V3.14.0 roles, missing CR and CRD for calico_kube_controller #6276

Conversation

nurekage commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

floryut commented Jun 16, 2020

hafe commented Jun 17, 2020

nurekage Jun 24, 2020 • edited Loading

Choose a reason for hiding this comment

floryut Jun 24, 2020

Choose a reason for hiding this comment

nurekage commented Jun 24, 2020

floryut commented Jun 25, 2020

hafe commented Jun 25, 2020

floryut commented Jun 29, 2020

hafe commented Jul 1, 2020

LuckySB commented Jul 1, 2020

k8s-ci-robot commented Jul 1, 2020

floryut commented Jul 1, 2020

nurekage Jun 24, 2020 •

edited

Loading