Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle Linux 8 support and fixes #6198

Merged
merged 4 commits into from
Jun 12, 2020
Merged

Oracle Linux 8 support and fixes #6198

merged 4 commits into from
Jun 12, 2020

Conversation

marcosfsch
Copy link
Contributor

As documented in [1], public-yum-ol7.repo was deprecated on release 7.6. Some repos were integrated into oracle-linux-ol7.repo (i.e.: ol7_latest, ol7_addons) and other are available as packages (epel). This also adds support for oraclelinux8

[1] http://yum.oracle.com/getting-started.html#installing-software-from-oracle-linux-yum-server

marcosfsch added 2 commits May 27, 2020 16:12
@marcosfsch
Add oraclelinux8 and disable firewalld
e34cad1 
Add oraclelinux8 image and disable firewalld on oraclelinux VMs
@marcosfsch
Fix Oracle Linux repositories
706bd41 
As documented in: http://yum.oracle.com/getting-started.html#installing-software-from-oracle-linux-yum-server
public-yum-ol7.repo was deprecated on release 7.6. Some repos were integrated into oracle-linux-ol7.repo (i.e.: ol7_latest, ol7_addons) and other are available as packages (epel). This also adds support for oraclelinux8
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @marcosfsch. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten May 27, 2020 20:20
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2020
@floryut
Copy link
Member

floryut commented May 27, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
@marcosfsch
Fix to use ansible_distribution_version
d2e528d 
Instead of ansible_distribution_major_version
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcosfsch, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 4, 2020

Thank you @marcosfsch, README.md probably needs to be updated as well

@floryut
Copy link
Member

floryut commented Jun 5, 2020 •
edited
Loading

@marcosfsch Can you update README as stated by @Miouge1 ?
We need to add Oracle Linux 8 as supported OS.

@floryut
Copy link
Member

floryut commented Jun 12, 2020

/lgtm
@marcosfsch if you can, submit another pr with an oracle8 CI test to validate all that, in the meantime let's merge this 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8dc01df into kubernetes-sigs:master Jun 12, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2020
@marcosfsch @LuckySB
Oracle Linux 8 support and fixes (kubernetes-sigs#6198)
e1f18b1 
* Add oraclelinux8 and disable firewalld

Add oraclelinux8 image and disable firewalld on oraclelinux VMs

* Fix Oracle Linux repositories

As documented in: http://yum.oracle.com/getting-started.html#installing-software-from-oracle-linux-yum-server
public-yum-ol7.repo was deprecated on release 7.6. Some repos were integrated into oracle-linux-ol7.repo (i.e.: ol7_latest, ol7_addons) and other are available as packages (epel). This also adds support for oraclelinux8

* Fix to use ansible_distribution_version

Instead of ansible_distribution_major_version

* Update README.md
@floryut floryut mentioned this pull request Aug 14, 2020
Closed
@SndR85 SndR85 mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcosfsch @k8s-ci-robot @floryut @Miouge1