Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weave: support any taint effect in daemonset tolerations #6159

Merged
merged 1 commit into from
May 28, 2020
Merged

weave: support any taint effect in daemonset tolerations #6159

merged 1 commit into from
May 28, 2020

Conversation

fydrah
Copy link
Contributor

@fydrah fydrah commented May 18, 2020 •
edited
Loading

Since weave 2.5.1, NoExecute taint effect is no more supported,
this changes the daemonset tolerations to change this behavior.

Also remove the toleration key CriticalAddonsOnly not required anymore.

What type of PR is this?

/kind bug

What this PR does / why we need it:

See #6158 description

Which issue(s) this PR fixes:

Fixes #6158

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@fydrah
weave: support any taint effect in daemonset tolerations
a1042d2 
Since weave 2.5.1, `NoExecute` taint effect is no more supported,
this changes the daemonset tolerations to change this behavior.

Also remove the toleration key `CriticalAddonsOnly` not required anymore.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @fydrah!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @fydrah. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut May 18, 2020 14:46
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2020
@floryut
Copy link
Member

floryut commented May 18, 2020

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2020
@fydrah
Copy link
Contributor Author

fydrah commented May 18, 2020

/assign @ant31

@Miouge1
Copy link
Contributor

Miouge1 commented May 20, 2020

@hswong3i any input on this?

@fydrah
Copy link
Contributor Author

fydrah commented May 21, 2020

It seems others plugin do not support all taint effect:

Maybe this issue could be extended to multiple cni, not only weave.

@Miouge1
Copy link
Contributor

Miouge1 commented May 28, 2020

@fydrah feel free to make another PR for the other plugins

/approved

@Miouge1
Copy link
Contributor

Miouge1 commented May 28, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fydrah, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit ab44beb into kubernetes-sigs:master May 28, 2020
@fydrah fydrah mentioned this pull request May 29, 2020
Merged
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
@fydrah @LuckySB
weave: support any taint effect in daemonset tolerations (kubernetes-…
92ab868 
…sigs#6159)

Since weave 2.5.1, `NoExecute` taint effect is no more supported,
this changes the daemonset tolerations to change this behavior.

Also remove the toleration key `CriticalAddonsOnly` not required anymore.
@floryut floryut mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

Assignees

@ant31 ant31

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CNI: Weave tolerations do not support "NoExecute" effects
5 participants
@fydrah @k8s-ci-robot @floryut @Miouge1 @ant31